Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Windows/arm64: 3 Improvements on 8/8/2023 7:20:25 PM #20603

Closed
performanceautofiler bot opened this issue Aug 17, 2023 · 1 comment
Closed

[Perf] Windows/arm64: 3 Improvements on 8/8/2023 7:20:25 PM #20603

performanceautofiler bot opened this issue Aug 17, 2023 · 1 comment

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Aug 17, 2023

Run Information

Name Value
Architecture arm64
OS Windows 10.0.19041
Queue SurfaceWindows
Baseline e857642fd03f8a6acdf42af7d9a814e320ec8432
Compare 88633ae045e7741fffa17710dc48e9032e519258
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Improvements in Microsoft.Extensions.Configuration.ConfigurationBinderBenchmarks

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
9.85 ms 6.76 ms 0.69 0.30 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'Microsoft.Extensions.Configuration.ConfigurationBinderBenchmarks*'

Payloads

Baseline
Compare

Microsoft.Extensions.Configuration.ConfigurationBinderBenchmarks.Get(ConfigurationProvidersCount: 32, KeysCountPerProvider: 10)

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed: Marked as improvement because 6.758676315789473 < 10.30005853125.
IsChangePoint: Marked as a change because one of 5/19/2023 4:22:12 AM, 7/12/2023 7:14:29 PM, 8/8/2023 8:10:39 AM, 8/16/2023 6:53:02 PM falls between 8/7/2023 10:39:59 PM and 8/16/2023 6:53:02 PM.
IsImprovementStdDev: Marked as improvement because 2.7538405212488333 (T) = (0 -6571464.761720457) / Math.Sqrt((2561643126707.319 / (299)) + (1813563340956.3489 / (15))) is greater than 1.9675964973877862 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (15) - 2, .975) and 0.13102944612713321 = (7562356.091851973 - 6571464.761720457) / 7562356.091851973 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository


Run Information

Name Value
Architecture arm64
OS Windows 10.0.19041
Queue SurfaceWindows
Baseline e857642fd03f8a6acdf42af7d9a814e320ec8432
Compare 88633ae045e7741fffa17710dc48e9032e519258
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Improvements in System.Tests.Perf_Double

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio
136.55 ns 123.40 ns 0.90 0.12 False
137.66 ns 121.61 ns 0.88 0.12 False

graph
graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'System.Tests.Perf_Double*'

Payloads

Baseline
Compare

System.Tests.Perf_Double.TryParse(value: "1.7976931348623157e+308")

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed: Marked as improvement because 123.39984547319985 < 129.69512506515048.
IsChangePoint: Marked as a change because one of 5/19/2023 4:22:12 AM, 6/22/2023 11:35:25 PM, 8/8/2023 8:10:39 AM, 8/16/2023 6:53:02 PM falls between 8/7/2023 10:39:59 PM and 8/16/2023 6:53:02 PM.
IsImprovementStdDev: Marked as improvement because 36.74720790796613 (T) = (0 -123.44448495588667) / Math.Sqrt((40.97048832643207 / (299)) + (0.02915942648206842 / (15))) is greater than 1.9675964973877862 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (15) - 2, .975) and 0.09988693684599242 = (137.14331011188264 - 123.44448495588667) / 137.14331011188264 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

System.Tests.Perf_Double.Parse(value: "1.7976931348623157e+308")

ETL Files

Histogram

Description of detection logic

IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsRegressionBase: Marked as not a regression because the compare was not 5% greater than the baseline, or the value was too small.
IsImprovementBase: Marked as improvement because the compare was 5% less than the baseline, and the value was not too small.
IsImprovementCheck: Marked as improvement because the three check build points were 0.05 less than the baseline.
IsImprovementWindowed: Marked as improvement because 121.60899900772645 < 130.8278659745647.
IsChangePoint: Marked as a change because one of 5/19/2023 4:22:12 AM, 6/22/2023 12:06:43 AM, 8/8/2023 8:10:39 AM, 8/16/2023 6:53:02 PM falls between 8/7/2023 10:39:59 PM and 8/16/2023 6:53:02 PM.
IsImprovementStdDev: Marked as improvement because 44.253338661526364 (T) = (0 -121.33799052000397) / Math.Sqrt((40.90667708372457 / (299)) + (0.026957983322730455 / (15))) is greater than 1.9675964973877862 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (299) + (15) - 2, .975) and 0.11954995296179247 = (137.81359990629707 - 121.33799052000397) / 137.81359990629707 is greater than 0.05.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

JIT Disasms

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@AndyAyersMS
Copy link
Member

Possibly dotnet/runtime#87438 dragging in more static PGO data?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant