Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestHostDocument doesn't support multiple positions #54762

Open
Youssef1313 opened this issue Jul 12, 2021 · 0 comments
Open

TestHostDocument doesn't support multiple positions #54762

Youssef1313 opened this issue Jul 12, 2021 · 0 comments
Assignees
Labels
Area-IDE Test Test failures in roslyn-CI Test-Gap Describes a specific feature or scenario that does not have test coverage
Milestone

Comments

@Youssef1313
Copy link
Member

Youssef1313 commented Jul 12, 2021

TestFileMarkupParser.GetPositionAndSpans(markupCode,
out var code, out int? cursorPosition, out ImmutableDictionary<string, ImmutableArray<TextSpan>> spans);

return new TestHostDocument(
exportProvider, languageServiceProvider, code, fileName, fileName, cursorPosition, spans, codeKind, folders, isLinkFile, documentServiceProvider);

Instead of GetPositionAndSpans, I want to use GetPositionsAndSpans, but TestHostDocument doesn't accept multiple positions. This blocks adding a test for #54741.

@sharwell

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 12, 2021
@jinujoseph jinujoseph added Test Test failures in roslyn-CI Test-Gap Describes a specific feature or scenario that does not have test coverage and removed untriaged Issues and PRs which have not yet been triaged by a lead labels Jul 14, 2021
@jinujoseph jinujoseph added this to the 17.0 milestone Jul 14, 2021
@jinujoseph jinujoseph modified the milestones: 17.0, 17.1 Oct 11, 2021
@jinujoseph jinujoseph modified the milestones: 17.1, 17.3 Apr 27, 2022
@arkalyanms arkalyanms modified the milestones: 17.3, 17.6 P2 Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE Test Test failures in roslyn-CI Test-Gap Describes a specific feature or scenario that does not have test coverage
Projects
None yet
Development

No branches or pull requests

4 participants