-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbol.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat) does not escape everything it should #74117
Comments
Sorry. I missed this was for creating a type syntax. The |
I'm a bit confused now. In my source generator, I want to emit the fully qualified name of a symbol. Should I use |
I could go either way here. It will generate a warning if it's a class name, so it feels like the safer thing to do is just escape it always. |
@CyrusNajmabadi, did you have a response to my comment? |
Fine with me always escape it. |
I think I've found a bug in Symbol.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat).
Previously, in my source generator, I used the following to get the fully qualified name:
value.FullName() ?? value.Name ?? throw new InvalidOperationException()
But it was recommended I use
.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat)
instead.But it doesn't escape everything it should.
Version Used:
Happens in all versions tested.
Steps to Reproduce:
In Vogen, my source generator, I look for
ValueObject
attributes and get a symbol from the underlying type argument. If I give the following horrendous (but legal) C#@... then I get different results. Here's the difference between the two:
Expected Behavior:
value.ToDisplayString(SymbolDisplayFormat.FullyQualifiedFormat)
should escapedecimal
. It might also want to escaperecord
Actual Behavior:
It doesn't escape
decimal
and leads to illegal C# code being emitted from my source generator.The text was updated successfully, but these errors were encountered: