From 6aa28625e3b86ae6894ab85ce592786f7c440ae0 Mon Sep 17 00:00:00 2001 From: Sven Boemer Date: Fri, 19 Jul 2024 09:33:34 -0700 Subject: [PATCH] Address feedback on DiagnosticId changes (#105096) See feedback in https://github.com/dotnet/runtime/pull/105049 --- src/tools/illink/src/ILLink.Shared/DiagnosticId.cs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/tools/illink/src/ILLink.Shared/DiagnosticId.cs b/src/tools/illink/src/ILLink.Shared/DiagnosticId.cs index f7c2c3f88dc1d..e94bc78320493 100644 --- a/src/tools/illink/src/ILLink.Shared/DiagnosticId.cs +++ b/src/tools/illink/src/ILLink.Shared/DiagnosticId.cs @@ -187,7 +187,7 @@ public enum DiagnosticId _unused_DynamicallyAccessedMembersOnTypeReferencesCompilerGeneratedMemberOnBase = 2120, RedundantSuppression = 2121, TypeNameIsNotAssemblyQualified = 2122, - _EndTrimAnalysisWarningsSentinel = 2123, + _EndTrimAnalysisWarningsSentinel, // Single-file diagnostic ids. AvoidAssemblyLocationInSingleFile = 3000, @@ -204,7 +204,7 @@ public enum DiagnosticId GenericRecursionCycle = 3054, CorrectnessOfAbstractDelegatesCannotBeGuaranteed = 3055, RequiresDynamicCodeOnStaticConstructor = 3056, - _EndAotAnalysisWarningsSentinel = 3057, + _EndAotAnalysisWarningsSentinel, // Feature guard diagnostic ids. ReturnValueDoesNotMatchFeatureGuards = 4000, @@ -229,9 +229,9 @@ public static string GetDiagnosticSubcategory (this DiagnosticId diagnosticId) = 2103 => MessageSubCategory.TrimAnalysis, 2106 => MessageSubCategory.TrimAnalysis, 2107 => MessageSubCategory.TrimAnalysis, - >= 2109 and <= (int) DiagnosticId._EndTrimAnalysisWarningsSentinel => MessageSubCategory.TrimAnalysis, + >= 2109 and < (int) DiagnosticId._EndTrimAnalysisWarningsSentinel => MessageSubCategory.TrimAnalysis, >= 3050 and <= 3052 => MessageSubCategory.AotAnalysis, - >= 3054 and <= (int) DiagnosticId._EndAotAnalysisWarningsSentinel => MessageSubCategory.AotAnalysis, + >= 3054 and < (int) DiagnosticId._EndAotAnalysisWarningsSentinel => MessageSubCategory.AotAnalysis, _ => MessageSubCategory.None, };