Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Text.Json.Tests.Utf8JsonWriterTests.WritingTooDeep failure #101470

Closed
lewing opened this issue Apr 24, 2024 · 5 comments · Fixed by #101498
Closed

System.Text.Json.Tests.Utf8JsonWriterTests.WritingTooDeep failure #101470

lewing opened this issue Apr 24, 2024 · 5 comments · Fixed by #101498
Assignees
Labels
area-System.Text.Json blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab
Milestone

Comments

@lewing
Copy link
Member

lewing commented Apr 24, 2024

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=652336
Build error leg or test failing: System.Text.Json.Tests.Utf8JsonWriterTests.WritingTooDeep
Pull request: #101379

Error Message

Fill the error message using step by step known issues guidance.

{
  "ErrorMessage": ["System.OutOfMemoryException : Exception of type 'System.OutOfMemoryException' was thrown.", "t System.Text.Json.Utf8JsonWriter.Grow(Int32 requiredSize)"],
  "ErrorPattern": "",
  "BuildRetry": false,
  "ExcludeConsoleLog": false
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=652336
Error message validated: [System.OutOfMemoryException : Exception of type 'System.OutOfMemoryException' was thrown. t System.Text.Json.Utf8JsonWriter.Grow(Int32 requiredSize)]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 4/24/2024 2:35:37 AM UTC

Report

Build Definition Test Pull Request
653219 dotnet/runtime System.Text.Json.Tests.Utf8JsonWriterTests.WriteRawMaxUtf16InputLength
652336 dotnet/runtime System.Text.Json.Tests.Utf8JsonWriterTests.WritingTooDeep #101379

Summary

24-Hour Hit Count 7-Day Hit Count 1-Month Count
0 2 2
@lewing lewing added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab labels Apr 24, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Apr 24, 2024
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-text-json, @gregsdennis
See info in area-owners.md if you want to be subscribed.

@lewing
Copy link
Member Author

lewing commented Apr 24, 2024

@lewing
Copy link
Member Author

lewing commented Apr 24, 2024

@jeffhandley the System.Text.Json test are OOMing across multiple tests and runtimes and we need some triage here

@lewing lewing changed the title stem.Text.Json.Tests.Utf8JsonWriterTests.WritingTooDeep failure System.Text.Json.Tests.Utf8JsonWriterTests.WritingTooDeep failure Apr 24, 2024
@eiriktsarpalis
Copy link
Member

This was presumably regressed by #100890 which added more test cases to the writer options.

@carlossanlop
Copy link
Member

I wonder if this failure is affecting more tests than the ones narrowed down by the ErrorMessage in this issue's json description.

Specifically, I'm referring to:

@github-actions github-actions bot locked and limited conversation to collaborators May 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Text.Json blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' Known Build Error Use this to report build issues in the .NET Helix tab
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants