Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dotnet-pgo used in build with new packages without ensuring matching framework #106983

Open
ericstj opened this issue Aug 26, 2024 · 2 comments · Fixed by #107343
Open

dotnet-pgo used in build with new packages without ensuring matching framework #106983

ericstj opened this issue Aug 26, 2024 · 2 comments · Fixed by #107343

Comments

@ericstj
Copy link
Member

ericstj commented Aug 26, 2024

Similar to #106740

Discovered in #106873 (comment)

ILCompiler projects are referencing a package version of System.Reflection.Metdata and copying that to the output and running it during the build, without ensuring that the runtime they are running against supports that version of the package.

@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Aug 26, 2024
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Aug 26, 2024
Copy link
Contributor

Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas
See info in area-owners.md if you want to be subscribed.

@teo-tsirpanis teo-tsirpanis removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 1, 2024
@dotnet-policy-service dotnet-policy-service bot added the in-pr There is an active PR which will close this issue when it is merged label Sep 4, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Sep 4, 2024
@MichalStrehovsky
Copy link
Member

I've deleted the S.R.Metadata package reference in ILCompiler.TypeSystem in #107343.

dotnet-pgo still doesn't work because it depends on ILCompiler.Reflection.ReadyToRun and that one does need a S.R.Metadata package reference because it's netstandard2.0 for ILSpy sake. If we could make it $(NetCoreAppToolCurrent), the problem would go away but that would break ILSpy. I don't know enough nuget-fu to resolve this. Reopening and moving to crossgen2 area path since this is not in a component shared with nativeaot anymore.

@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Sep 4, 2024
@MichalStrehovsky MichalStrehovsky added area-crossgen2-coreclr and removed untriaged New issue has not been triaged by the area owner area-NativeAOT-coreclr in-pr There is an active PR which will close this issue when it is merged labels Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

5 participants
@ericstj @jeffschwMSFT @teo-tsirpanis @MichalStrehovsky and others