Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ICU is not packaged when Invariant mode is enabled #35090

Open
steveisok opened this issue Apr 17, 2020 · 3 comments
Open

Ensure ICU is not packaged when Invariant mode is enabled #35090

steveisok opened this issue Apr 17, 2020 · 3 comments
Assignees
Milestone

Comments

@steveisok
Copy link
Member

steveisok commented Apr 17, 2020

When Invariant mode is enabled and we are publishing for iOS / tvOS, we must ensure that no ICU artifacts are produced.

Example:
dotnet publish <required-args> /p:InvariantGlobalization=true

No ICU binaries should be in the publish folder.

@ghost
Copy link

ghost commented Apr 17, 2020

Tagging subscribers to this area: @directhex
Notify danmosemsft if you want to be subscribed.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Apr 17, 2020
@akoeplinger
Copy link
Member

Using the env var is a bad idea, we should rather use the InvariantGlobalization MSBuild property: https://docs.microsoft.com/en-us/dotnet/core/run-time-config/globalization#invariant-mode

@steveisok
Copy link
Member Author

I updated the example. I meant it to be 'pick any option to enable' ;-).

@danmoseley danmoseley modified the milestones: 5.0.0, 6.0.0 Jun 16, 2020
@marek-safar marek-safar removed the untriaged New issue has not been triaged by the area owner label Jun 24, 2020
@steveisok steveisok modified the milestones: 6.0.0, 7.0.0 Jul 26, 2021
@steveisok steveisok modified the milestones: 7.0.0, Future Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants