Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Definition of IsBlittable doesn't match runtime #46738

Closed
MichalStrehovsky opened this issue Jan 8, 2021 · 0 comments · Fixed by #46769
Closed

Definition of IsBlittable doesn't match runtime #46738

MichalStrehovsky opened this issue Jan 8, 2021 · 0 comments · Fixed by #46769
Labels
area-crossgen2-coreclr
Milestone
6.0.0

Comments

@MichalStrehovsky
Copy link
Member

#46653 (comment)

Crossgen2 is missing this logic. I haven't investigated whether this can cause actual issues currently, but per the pull request it's clear we don't have any tests for this but customers do rely on this.

The test added in the pull request won't exercise crossgen2 logic but blittability is definitely used to make decisions in crossgen2.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the untriaged New issue has not been triaged by the area owner label Jan 8, 2021
@MichalStrehovsky MichalStrehovsky mentioned this issue Jan 8, 2021
Merged
@am11 am11 mentioned this issue Jan 8, 2021
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Jan 8, 2021
@AaronRobinsonMSFT AaronRobinsonMSFT removed the untriaged New issue has not been triaged by the area owner label Jan 9, 2021
@AaronRobinsonMSFT AaronRobinsonMSFT added this to the 6.0.0 milestone Jan 9, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Jan 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Feb 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area-crossgen2-coreclr
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Classify type with empty base as non-blittable
3 participants
@MichalStrehovsky @AaronRobinsonMSFT @Dotnet-GitSync-Bot