Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DualMode sockets consistently in BCL #47586

Open
antonfirsov opened this issue Jan 28, 2021 · 3 comments
Open

Use DualMode sockets consistently in BCL #47586

antonfirsov opened this issue Jan 28, 2021 · 3 comments
Labels
area-System.Net enhancement Product code improvement that does NOT require public API changes/additions
Milestone
Future

Comments

@antonfirsov
Copy link
Member

Following up on #47058 (comment) and offline discussions:

Currently our use of dual-stack sockets is inconsistent and depends on historical factors. (See #46724 as an example.)
We should prefer Dual Stack whenever possible, and implement #47583 to provide a workaround for cases when it leads to a problem.

Alternatively, we may implement Happy Eyeballs (#861, #26177), and migrate to it in our socket usages, but it's a much bigger change and may bring compatibility issues.
@dotnet-issue-labeler dotnet-issue-labeler bot added area-System.Net.Sockets untriaged New issue has not been triaged by the area owner labels Jan 28, 2021
@ghost
Copy link

ghost commented Jan 28, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Following up on #47058 (comment) and offline discussions:

Currently our use of dual-stack sockets is inconsistent and depends on historical factors. (See #46724 as an example.)
We should prefer Dual Stack whenever possible, and implement #47583 to provide a workaround for cases when it leads to a problem.

Alternatively, we may implement Happy Eyeballs (#861, #26177), and migrate to it in our socket usages, but it's a much bigger change and may bring compatibility issues.

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Sockets, untriaged
Milestone: -

@ghost
Copy link

ghost commented Jan 28, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Following up on #47058 (comment) and offline discussions:

Currently our use of dual-stack sockets is inconsistent and depends on historical factors. (See #46724 as an example.)
We should prefer Dual Stack whenever possible, and implement #47583 to provide a workaround for cases when it leads to a problem.

Alternatively, we may implement Happy Eyeballs (#861, #26177), and migrate to it in our socket usages, but it's a much bigger change and may bring compatibility issues.

Author: antonfirsov
Assignees: -
Labels:

area-System.Net, untriaged
Milestone: -

@karelz karelz added the design-discussion Ongoing discussion about design without consensus label Feb 2, 2021
@karelz
Copy link
Member

karelz commented Feb 16, 2021

Triage: Nice to have, removes some duplicate code
We're committed to DualMode sockets (starting with SocketsHttpHandler)
May be better to do in larger PR rather than one by one.

@karelz karelz added this to the Future milestone Feb 16, 2021
@karelz karelz added enhancement Product code improvement that does NOT require public API changes/additions and removed design-discussion Ongoing discussion about design without consensus untriaged New issue has not been triaged by the area owner labels Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-System.Net enhancement Product code improvement that does NOT require public API changes/additions
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@karelz @antonfirsov