Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate removing MacOS entitlements on the dotnet host #50185

Closed
mikem8361 opened this issue Mar 24, 2021 · 4 comments
Closed

Investigate removing MacOS entitlements on the dotnet host #50185

mikem8361 opened this issue Mar 24, 2021 · 4 comments
Milestone

Comments

@mikem8361
Copy link
Member

Investigate if these dotnet host current entitlements are necessary:

com.apple.security.cs.allow-unsigned-executable-memory
com.apple.security.cs.allow-dyld-environment-variables

https://github.com/dotnet/runtime/blob/main/eng/pipelines/common/entitlements.plist

There will be testing and investigation to make sure removing them doesn't break anything.

Oded Hanson:

We only needed com.apple.security.cs.allow-jit but, indeed the process doesn't inherit the default DYLIB search paths and we need to manually add :/usr/local/lib:/usr/lib to the NATIVE_DLL_SEARCH_DIRECTORIES. I guess com.apple.security.cs.allow-dyld-environment-variables would have solved that, instead of adding the paths explicitly.

@mikem8361 mikem8361 added this to the 6.0.0 milestone Mar 24, 2021
@ghost
Copy link

ghost commented Mar 24, 2021

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

Investigate if these dotnet host current entitlements are necessary:

com.apple.security.cs.allow-unsigned-executable-memory
com.apple.security.cs.allow-dyld-environment-variables

https://github.com/dotnet/runtime/blob/main/eng/pipelines/common/entitlements.plist

There will be testing and investigation to make sure removing them doesn't break anything.

Oded Hanson:

We only needed com.apple.security.cs.allow-jit but, indeed the process doesn't inherit the default DYLIB search paths and we need to manually add :/usr/local/lib:/usr/lib to the NATIVE_DLL_SEARCH_DIRECTORIES. I guess com.apple.security.cs.allow-dyld-environment-variables would have solved that, instead of adding the paths explicitly.

Author: mikem8361
Assignees: -
Labels:

area-Host

Milestone: 6.0.0

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Mar 24, 2021
@vitek-karas
Copy link
Member

/cc @VSadov

@akoeplinger
Copy link
Member

akoeplinger commented Jun 16, 2021

com.apple.security.cs.allow-unsigned-executable-memory was done by #51294 I think

@jeffschwMSFT jeffschwMSFT removed the untriaged New issue has not been triaged by the area owner label Jul 6, 2021
@agocke
Copy link
Member

agocke commented Jul 29, 2021

I think this is done. #51294 closed out the only change we'd likely make here.

@agocke agocke closed this as completed Jul 29, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants