Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][eat] Failing test because of "Use of ResourceManager for custom types is disabled" #51833

Closed
radical opened this issue Apr 25, 2021 · 4 comments
Closed

[wasm][eat] Failing test because of "Use of ResourceManager for custom types is disabled" #51833

radical opened this issue Apr 25, 2021 · 4 comments
Labels
arch-wasm WebAssembly architecture area-System.Resources test-enhancement Improvements of test source code trimming-for-aot `EnableAggressiveTrimming=true` used for running tests with AOT
Milestone
Future

Comments

@radical
Copy link
Member

radical commented Apr 25, 2021

Log

[10:34:52] fail: [FAIL] System.Resources.ResourceWriterTests.ResourceReaderTests.ReadV1Resources
[10:34:52] info: System.NotSupportedException : Use of ResourceManager for custom types is disabled. Set the MSBuild Property CustomResourceTypesSupport to true in order to enable it.
[10:34:52] info:    at System.Resources.ResourceReader.FindType(Int32 typeIndex)
[10:34:52] info:    at System.Resources.ResourceReader._LoadObjectV1(Int32 pos)
[10:34:52] info:    at System.Resources.ResourceReader.LoadObjectV1(Int32 pos)
[10:34:52] info:    at System.Resources.ResourceReader.LoadObject(Int32 pos)
[10:34:52] info:    at System.Resources.ResourceReader.ResourceEnumerator.get_Entry()
[10:34:52] info:    at System.Resources.ResourceReader.ResourceEnumerator.get_Current()
[10:34:52] info:    at System.Resources.ResourceWriterTests.ResourceReaderTests.ReadV1Resources()
[10:34:52] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
@radical radical added arch-wasm WebAssembly architecture area-Build-mono trimming-for-aot `EnableAggressiveTrimming=true` used for running tests with AOT labels Apr 25, 2021
@ghost
Copy link

ghost commented Apr 25, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Log

[10:34:52] fail: [FAIL] System.Resources.ResourceWriterTests.ResourceReaderTests.ReadV1Resources
[10:34:52] info: System.NotSupportedException : Use of ResourceManager for custom types is disabled. Set the MSBuild Property CustomResourceTypesSupport to true in order to enable it.
[10:34:52] info:    at System.Resources.ResourceReader.FindType(Int32 typeIndex)
[10:34:52] info:    at System.Resources.ResourceReader._LoadObjectV1(Int32 pos)
[10:34:52] info:    at System.Resources.ResourceReader.LoadObjectV1(Int32 pos)
[10:34:52] info:    at System.Resources.ResourceReader.LoadObject(Int32 pos)
[10:34:52] info:    at System.Resources.ResourceReader.ResourceEnumerator.get_Entry()
[10:34:52] info:    at System.Resources.ResourceReader.ResourceEnumerator.get_Current()
[10:34:52] info:    at System.Resources.ResourceWriterTests.ResourceReaderTests.ReadV1Resources()
[10:34:52] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono, trimming-for-aot
Milestone: -

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Apr 25, 2021
@lewing lewing added this to the 6.0.0 milestone Jun 17, 2021
@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Jun 17, 2021
@marek-safar
Copy link
Contributor

This is a test issue where the test should be conditional on

runtime/src/libraries/System.Private.CoreLib/src/System/Resources/ResourceReader.cs

Line 131 in 57bfe47

internal static bool AllowCustomResourceTypes { get; } = AppContext.TryGetSwitch("System.Resources.ResourceManager.AllowCustomResourceTypes", out bool allowReflection) ? allowReflection : true;

@ghost
Copy link

ghost commented Jul 2, 2021

Tagging subscribers to this area: @tarekgh, @buyaa-n, @krwq
See info in area-owners.md if you want to be subscribed.

Issue Details

Log

[10:34:52] fail: [FAIL] System.Resources.ResourceWriterTests.ResourceReaderTests.ReadV1Resources
[10:34:52] info: System.NotSupportedException : Use of ResourceManager for custom types is disabled. Set the MSBuild Property CustomResourceTypesSupport to true in order to enable it.
[10:34:52] info:    at System.Resources.ResourceReader.FindType(Int32 typeIndex)
[10:34:52] info:    at System.Resources.ResourceReader._LoadObjectV1(Int32 pos)
[10:34:52] info:    at System.Resources.ResourceReader.LoadObjectV1(Int32 pos)
[10:34:52] info:    at System.Resources.ResourceReader.LoadObject(Int32 pos)
[10:34:52] info:    at System.Resources.ResourceReader.ResourceEnumerator.get_Entry()
[10:34:52] info:    at System.Resources.ResourceReader.ResourceEnumerator.get_Current()
[10:34:52] info:    at System.Resources.ResourceWriterTests.ResourceReaderTests.ReadV1Resources()
[10:34:52] info:    at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono, area-System.Resources, trimming-for-aot
Milestone: 6.0.0

@marek-safar marek-safar modified the milestones: 6.0.0, Future Jul 2, 2021
@marek-safar marek-safar added test-enhancement Improvements of test source code and removed area-Build-mono labels Jul 2, 2021
@MichalStrehovsky MichalStrehovsky mentioned this issue Jul 20, 2022
Merged
@MichalStrehovsky
Copy link
Member

Fixed in #72497

@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.Resources test-enhancement Improvements of test source code trimming-for-aot `EnableAggressiveTrimming=true` used for running tests with AOT
Projects
No open projects
Triage POD for Reflection, META, etc.
Status: Done
Milestone
Future
Development

No branches or pull requests
4 participants
@radical @lewing @marek-safar @MichalStrehovsky