Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship runtime using DllImportGenerator #60212

Closed
13 tasks done
elinor-fung opened this issue Oct 9, 2021 · 3 comments
Closed
13 tasks done

Ship runtime using DllImportGenerator #60212

elinor-fung opened this issue Oct 9, 2021 · 3 comments

Comments

@elinor-fung
Copy link
Member

elinor-fung commented Oct 9, 2021

Issues to address after the initial merge (#59579):

Runtime issues discovered by DllImportGenerator

cc @AaronRobinsonMSFT @jkoritzinsky

@elinor-fung elinor-fung added this to the 7.0.0 milestone Oct 9, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Oct 9, 2021
@elinor-fung elinor-fung removed the untriaged New issue has not been triaged by the area owner label Oct 9, 2021
@jkotas
Copy link
Member

jkotas commented Oct 9, 2021

Allow each marshaller to specify its support

Can this be done by checking availability of the APIs required by the given marshaller?

@jkoritzinsky
Copy link
Member

Yes, I believe we can design this such that each marshaller can validate that the APIs it uses are available.

@elinor-fung
Copy link
Member Author

elinor-fung commented Jan 26, 2022

Remaining work for DllImportGenerator - including DisableRuntimeMarshalling for blittable/unmanaged reconciliation - is being tracked in #60595.

This is the drop in generated IL stubs on launch of some template applications after the use of DllImportGenerator in runtime libraries (most remaining stubs in the frameworks):

Template 6.0 7.0
console 2 0
webapp 55 18
winforms 65 55
wpf 129 123

@ghost ghost locked as resolved and limited conversation to collaborators Feb 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants