Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Implement ValueTask marshaling #61368

Closed
maraf opened this issue Nov 9, 2021 · 4 comments · Fixed by #94560
Closed

[wasm] Implement ValueTask marshaling #61368

maraf opened this issue Nov 9, 2021 · 4 comments · Fixed by #94560
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Milestone
Future

Comments

@maraf
Copy link
Member

maraf commented Nov 9, 2021

In #61324 we added tests for marshalling ValueTask and ValueTask<T> and this a tracking issue to implement the marshaller.
@maraf maraf added this to the 7.0.0 milestone Nov 9, 2021
@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Nov 9, 2021
@ghost
Copy link

ghost commented Nov 9, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

In #61324 we added tests for marshalling ValueTask and ValueTask<T> and this a tracking issue to implement the marshaller.

Author: maraf
Assignees: -
Labels:

arch-wasm, area-System.Runtime.InteropServices.JavaScript
Milestone: 7.0.0

@lewing lewing removed the untriaged New issue has not been triaged by the area owner label Nov 9, 2021
@lewing
Copy link
Member

lewing commented Nov 9, 2021

This should be a test case for the marshaling improvements.

@pavelsavara pavelsavara changed the title [wasm] Inplement ValueTask marshaling [wasm] Implement ValueTask marshaling Nov 9, 2021
@maraf
Copy link
Member Author

maraf commented Jun 22, 2022

The interop API is being reimplemented and this will not to fit in 7.0.

@maraf maraf modified the milestones: 7.0.0, Future Jun 22, 2022
@pavelsavara
Copy link
Member

I believe that Task which are proxies for JS Promise are not lightweight object and it's not clear to me if they could be.
I think we should delete the disabled tests and close this issue.

@pavelsavara pavelsavara added the os-browser Browser variant of arch-wasm label Nov 9, 2023
@maraf maraf mentioned this issue Nov 9, 2023
Merged
@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Nov 9, 2023
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Nov 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

[browser] Remove ValueTask interop test placeholders maraf/runtime
3 participants
@lewing @pavelsavara @maraf