Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm] Figure out a way to detect wasm+windows+aot for tests #61720

Open
radical opened this issue Nov 17, 2021 · 2 comments
Open

[wasm] Figure out a way to detect wasm+windows+aot for tests #61720

radical opened this issue Nov 17, 2021 · 2 comments
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono disabled-test The test is disabled in source code against the issue
Milestone
Future

Comments

@radical
Copy link
Member

radical commented Nov 17, 2021

#59479 enables AOT tests on windows, and needs to disable some tests. But we need to be able to detect WASM/Browser+Windows-host case, and surface to PlatformDetection.
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@dotnet-issue-labeler dotnet-issue-labeler bot added the untriaged New issue has not been triaged by the area owner label Nov 17, 2021
@radical radical added arch-wasm WebAssembly architecture and removed untriaged New issue has not been triaged by the area owner labels Nov 17, 2021
@ghost
Copy link

ghost commented Nov 17, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

#59479 enables AOT tests on windows, and needs to disable some tests. But we need to be able to detect WASM/Browser+Windows-host case, and surface to PlatformDetection.

Author: radical
Assignees: -
Labels:

arch-wasm
Milestone: -

@radical radical added the disabled-test The test is disabled in source code against the issue label Nov 17, 2021
@radical radical mentioned this issue Nov 17, 2021
Merged
@lewing lewing added this to the Future milestone Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono disabled-test The test is disabled in source code against the issue
Projects
None yet
Milestone
Future
Development

No branches or pull requests
3 participants
@radical @lewing @jeffschwMSFT