Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System.Windows.Extensions outerloop test SoundPlayerTests.LoadAsync_SourceLocationFromNetwork_Success failing #62305

Closed
buyaa-n opened this issue Dec 2, 2021 · 3 comments · Fixed by #62323

Comments

@buyaa-n
Copy link
Member

buyaa-n commented Dec 2, 2021

Outerloop test SoundPlayerTests.LoadAsync_SourceLocationFromNetwork_Success(String sourceLocation) is failing

Found in the build

C:\h\w\ACCB09AD\w\AD9E09AC\e>"C:\h\w\ACCB09AD\p\dotnet.exe" exec --runtimeconfig System.Windows.Extensions.Tests.runtimeconfig.json --depsfile System.Windows.Extensions.Tests.deps.json xunit.console.dll System.Windows.Extensions.Tests.dll -xml testResults.xml -nologo -nocolor -trait category=OuterLoop -notrait category=IgnoreForCI -notrait category=failing  
  Discovering: System.Windows.Extensions.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Windows.Extensions.Tests (found 11 of 43 test cases)
  Starting:    System.Windows.Extensions.Tests (parallel test collections = on, max threads = 2)
Process terminated. Assertion failed.
   at System.Media.SoundPlayer.LoadStream(Boolean loadSync) in /_/src/libraries/System.Windows.Extensions/src/System/Media/SoundPlayer.cs:line 311
   at System.Media.SoundPlayer.LoadAsync() in /_/src/libraries/System.Windows.Extensions/src/System/Media/SoundPlayer.cs:line 162
   at System.Media.Test.SoundPlayerTests.LoadAsync_SourceLocationFromNetwork_Success(String sourceLocation) in /_/src/libraries/System.Windows.Extensions/tests/System/Media/SoundPlayerTests.cs:line 134

Seem more log

@dotnet-issue-labeler dotnet-issue-labeler bot added area-Microsoft.Win32 untriaged New issue has not been triaged by the area owner labels Dec 2, 2021
@danmoseley
Copy link
Member

danmoseley commented Dec 3, 2021

@huoyaoyuan this was broken by 89e3040 #57896. This assert is requiring that there be a stream set up at the start of the method that I guess in this case is going to end up setting up the stream.

Note, these tests are OuterLoop so you wouldn't have seen it locally. You have to do something like dotnet build /t:test /p:outerloop=true .../tests/System.Windows.Extensions.csproj

@danmoseley
Copy link
Member

Do you remember any context on this one? I wonder if rather it should be if (loadSync && _stream!.CanSeek) and possibly should assert that _stream == null if loadSync is false. I didn't examine closely. Happy for one of us to take this issue unless you want to.

Also, I wonder why this wasn't reported before, since I see the change was months ago, we do run outer loop tests continuously.

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Dec 3, 2021
@danmoseley
Copy link
Member

I threw up a PR.

@buyaa-n buyaa-n removed the untriaged New issue has not been triaged by the area owner label Dec 3, 2021
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Dec 3, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jan 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants