Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failure - S.R.Tests.ControlledExecutionTests.CancelOnTimeout_ThrowFromFinally on `Libraries Test Run checked coreclr Linux arm64 Debug #73647

Closed
radical opened this issue Aug 9, 2022 · 4 comments · Fixed by #74136
Labels
area-System.Runtime blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' blocking-release test-failure
Milestone

Comments

@radical
Copy link
Member

radical commented Aug 9, 2022

Build for Libraries Test Run checked coreclr Linux arm64 Debug:

   System.Runtime.Tests.ControlledExecutionTests.CancelOnTimeout_ThrowFromFinally [FAIL]
      Assert.True() Failure
      Expected: True
      Actual:   False
      Stack Trace:
        /_/src/libraries/System.Runtime/tests/System/Runtime/ControlledExecutionTests.cs(56,0): at System.Runtime.Tests.ControlledExecutionTests.CancelOnTimeout_ThrowFromFinally()
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
        /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodInvoker.cs(69,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
@radical radical added blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' test-failure labels Aug 9, 2022
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Aug 10, 2022

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Build for Libraries Test Run checked coreclr Linux arm64 Debug:

   System.Runtime.Tests.ControlledExecutionTests.CancelOnTimeout_ThrowFromFinally [FAIL]
      Assert.True() Failure
      Expected: True
      Actual:   False
      Stack Trace:
        /_/src/libraries/System.Runtime/tests/System/Runtime/ControlledExecutionTests.cs(56,0): at System.Runtime.Tests.ControlledExecutionTests.CancelOnTimeout_ThrowFromFinally()
           at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
        /_/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodInvoker.cs(69,0): at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)
Author: radical
Assignees: -
Labels:

area-System.Runtime, blocking-clean-ci, untriaged, test-failure

Milestone: -

@jeffhandley jeffhandley added this to the 7.0.0 milestone Aug 15, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Aug 15, 2022
@jeffhandley
Copy link
Member

@steveharter It looks like Reflection might be in the call stack here and a couple folks from this area pod are away from work right now. Can you take a look please?

@steveharter
Copy link
Member

It looks like Reflection might be in the call stack here

Reflection is only in the call stack because XUnit uses reflection to invoke the test methods.

Likely related to #73739 since they use the same test helpers and the failure occurred around the same date.

The failure indicates the actual target test method LengthyAction_ThrowFromFinally was not called, since the first line of code in that method sets _startedExecution = true and the assert that is failing checks against that.

Stack is:

RunTest(LengthyAction_ThrowFromFinally, cts.Token);
->ControlledExecution.Run(action, cancellationToken);

And since ControlledExectution is new, that should be investigated -- AntonLapounov PTAL.

@steveharter steveharter removed their assignment Aug 15, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Runtime blocking-clean-ci Blocking PR or rolling runs of 'runtime' or 'runtime-extra-platforms' blocking-release test-failure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants