Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Regression: Crash on running debugger tests on Codespaces #73673

Closed
radical opened this issue Aug 10, 2022 · 2 comments · Fixed by #73702
Closed

[wasm] Regression: Crash on running debugger tests on Codespaces #73673

radical opened this issue Aug 10, 2022 · 2 comments · Fixed by #73702
Assignees
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Milestone

Comments

@radical
Copy link
Member

radical commented Aug 10, 2022

Running debugger tests on codespaces now breaks with:

  Error Message:
   System.ArgumentException : {
  "timestamp": 1660098231978.708,
  "exceptionDetails": {
    "exceptionId": 1,
    "text": "Uncaught (in promise)",
    "lineNumber": 2,
    "columnNumber": 64026,
    "scriptId": "6",
    "url": "http://localhost:9400/dotnet.js",
    "exception": {
      "type": "object",
      "subtype": "error",
      "className": "TypeError",
      "description": "TypeError: Failed to fetch\n    at Object._s [as fetch_like] (http://localhost:9400/dotnet.js:3:64027)\n    at Do (http://localhost:9400/dotnet.js:3:51275)\n    at Po (http://localhost:9400/dotnet.js:3:51927)\n    at Uo (http://localhost:9400/dotnet.js:3:52273)\n    at Mo (http://localhost:9400/dotnet.js:3:50662)\n    at ko (http://localhost:9400/dotnet.js:3:50245)\n    at Ec (http://localhost:9400/dotnet.js:5:48267)\n    at http://localhost:9400/dotnet.js:5:46311",
      "objectId": "8367169025981544960.1.1",
      "preview": {
        "type": "object",
        "subtype": "error",
        "description": "TypeError: Failed to fetch\n    at Object._s [as fetch_like] (http://localhost:9400/dotnet.js:3:64027)\n    at Do (http://localhost:9400/dotnet.js:3:51275)\n    at Po (http://localhost:9400/dotnet.js:3:51927)\n    at Uo (http://localhost:9400/dotnet.js:3:52273)\n    at Mo (http://localhost:9400/dotnet.js:3:50662)\n    at ko (http://localhost:9400/dotnet.js:3:50245)\n    at Ec (http://localhost:9400/dotnet.js:5:48267)\n    at http://localhost:9400/dotnet.js:5:46311",
        "overflow": false,
        "properties": [
          {
            "name": "stack",
            "type": "string",
            "value": "TypeError: Failed to fetch\n    at Object._s [as fe…7)\n    at http://localhost:9400/dotnet.js:5:46311"
          },
          {
            "name": "message",
            "type": "string",
            "value": "Failed to fetch"
          }
        ]
      }
    },
    "executionContextId": 1,
    "exceptionMetaData": {
      "requestId": "3089.71"
    }
  },
  "__forMethod": "Runtime.exceptionThrown"
}
  Stack Trace:
     at DebuggerTests.Inspector.OpenSessionAsync(Func`3 getInitCmds, TimeSpan span) in /workspaces/runtime/src/mono/wasm/debugger/DebuggerTestSuite/Inspector.cs:line 343
   at DebuggerTests.DebuggerTestBase.InitializeAsync() in /workspaces/runtime/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 149

.. making codespaces completely unusable for debugger work.
Reverting de03d8a fixes it.

commit de03d8a8c84062e04c5c7ad574bd7bb7e58db9a9
Author: Pavel Savara <pavel.savara@gmail.com>
Date:   Tue Aug 9 18:54:49 2022 +0200

    [wasm] asset loading for workers (#73484)

    - move asset related logic to separate file`assets.ts`
    - split logging code into separate file `logging.ts`
    - add `dotnet.wasm` and `dotnet-crypto-worker.js` to mono-config.json
    - moved `readSymbolMapFile()` call to `startup.ts`
    - fixed bug in `setup_proxy_console()` which didn't really copy the original `log` and `error` functions of the console and caused recursion on error.
    - moved `init_crypto` after `mono_wasm_load_config` in `mono_wasm_pre_init_essential_async`
    - added new resource type `js-module-crypto` and `js-module-threads`
    - changed the detection of blazor startup sequence to not be disabled by presence of config, but only by config.assets having some assembly in it.

    Co-authored-by: Marek Fišera <mara@neptuo.com>

Users could probably run into this too.

@radical radical added arch-wasm WebAssembly architecture area-Debugger-mono labels Aug 10, 2022
@radical radical added this to the 7.0.0 milestone Aug 10, 2022
@ghost
Copy link

ghost commented Aug 10, 2022

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Running debugger tests on codespaces now breaks with:

  Error Message:
   System.ArgumentException : {
  "timestamp": 1660098231978.708,
  "exceptionDetails": {
    "exceptionId": 1,
    "text": "Uncaught (in promise)",
    "lineNumber": 2,
    "columnNumber": 64026,
    "scriptId": "6",
    "url": "http://localhost:9400/dotnet.js",
    "exception": {
      "type": "object",
      "subtype": "error",
      "className": "TypeError",
      "description": "TypeError: Failed to fetch\n    at Object._s [as fetch_like] (http://localhost:9400/dotnet.js:3:64027)\n    at Do (http://localhost:9400/dotnet.js:3:51275)\n    at Po (http://localhost:9400/dotnet.js:3:51927)\n    at Uo (http://localhost:9400/dotnet.js:3:52273)\n    at Mo (http://localhost:9400/dotnet.js:3:50662)\n    at ko (http://localhost:9400/dotnet.js:3:50245)\n    at Ec (http://localhost:9400/dotnet.js:5:48267)\n    at http://localhost:9400/dotnet.js:5:46311",
      "objectId": "8367169025981544960.1.1",
      "preview": {
        "type": "object",
        "subtype": "error",
        "description": "TypeError: Failed to fetch\n    at Object._s [as fetch_like] (http://localhost:9400/dotnet.js:3:64027)\n    at Do (http://localhost:9400/dotnet.js:3:51275)\n    at Po (http://localhost:9400/dotnet.js:3:51927)\n    at Uo (http://localhost:9400/dotnet.js:3:52273)\n    at Mo (http://localhost:9400/dotnet.js:3:50662)\n    at ko (http://localhost:9400/dotnet.js:3:50245)\n    at Ec (http://localhost:9400/dotnet.js:5:48267)\n    at http://localhost:9400/dotnet.js:5:46311",
        "overflow": false,
        "properties": [
          {
            "name": "stack",
            "type": "string",
            "value": "TypeError: Failed to fetch\n    at Object._s [as fe…7)\n    at http://localhost:9400/dotnet.js:5:46311"
          },
          {
            "name": "message",
            "type": "string",
            "value": "Failed to fetch"
          }
        ]
      }
    },
    "executionContextId": 1,
    "exceptionMetaData": {
      "requestId": "3089.71"
    }
  },
  "__forMethod": "Runtime.exceptionThrown"
}
  Stack Trace:
     at DebuggerTests.Inspector.OpenSessionAsync(Func`3 getInitCmds, TimeSpan span) in /workspaces/runtime/src/mono/wasm/debugger/DebuggerTestSuite/Inspector.cs:line 343
   at DebuggerTests.DebuggerTestBase.InitializeAsync() in /workspaces/runtime/src/mono/wasm/debugger/DebuggerTestSuite/DebuggerTestBase.cs:line 149

.. making codespaces completely unusable for debugger work.
Reverting de03d8a fixes it.

commit de03d8a8c84062e04c5c7ad574bd7bb7e58db9a9
Author: Pavel Savara <pavel.savara@gmail.com>
Date:   Tue Aug 9 18:54:49 2022 +0200

    [wasm] asset loading for workers (#73484)

    - move asset related logic to separate file`assets.ts`
    - split logging code into separate file `logging.ts`
    - add `dotnet.wasm` and `dotnet-crypto-worker.js` to mono-config.json
    - moved `readSymbolMapFile()` call to `startup.ts`
    - fixed bug in `setup_proxy_console()` which didn't really copy the original `log` and `error` functions of the console and caused recursion on error.
    - moved `init_crypto` after `mono_wasm_load_config` in `mono_wasm_pre_init_essential_async`
    - added new resource type `js-module-crypto` and `js-module-threads`
    - changed the detection of blazor startup sequence to not be disabled by presence of config, but only by config.assets having some assembly in it.

    Co-authored-by: Marek Fišera <mara@neptuo.com>

Users could probably run into this too.

Author: radical
Assignees: -
Labels:

arch-wasm, area-Debugger-mono

Milestone: 7.0.0

@pavelsavara
Copy link
Member

This is related to throttling and performance of codespaces.
image

@ghost ghost added the in-pr There is an active PR which will close this issue when it is merged label Aug 10, 2022
@ghost ghost removed the in-pr There is an active PR which will close this issue when it is merged label Aug 11, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Sep 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-Debugger-mono
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants