LoggingScopeHttpMessageHandler should not log unredacted Uri

[evgenyfedorov2]

Description

LoggingScopeHttpMessageHandler logs HttpMethod and Uri here. While HttpMethod is safe to log, Uri is not, it often contains sensitive information which is a huge risk.

Reproduction Steps

Use HttpClient to send a request:

using var httpRequestMessage = new HttpRequestMessage
{
    Method = HttpMethod.Post,
    RequestUri = new("http://localhost/images/12345"),
};
_ = await _httpClient.SendAsync(httpRequestMessage, cancellationToken).ConfigureAwait(false);

Expected behavior

Either of those:

• An option to redact the URI which is enabled by default, so that by default the output would be:

HttpMethod:POST
Uri:http://localhost/images/<this was redacted>
{OriginalFormat}:HTTP {HttpMethod} {Uri} 

• Remove Uri from logging

Actual behavior

ILogger's scope contains this:

HttpMethod:POST
Uri:http://localhost/images/12345
{OriginalFormat}:HTTP {HttpMethod} {Uri} 

where 12345 is my privacy information

Regression?

No response

Known Workarounds

The only way is services.RemoveAll<IHttpMessageHandlerBuilderFilter>(); which is harsh. I need logging, but don't want to be exposed to a risk of leaking sensitive information

Configuration

No response

Other information

No response

[ghost]

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

LoggingScopeHttpMessageHandler logs HttpMethod and Uri here. While HttpMethod is safe to log, Uri is not, it often contains sensitive information which is a huge risk.

Reproduction Steps

Use HttpClient to Send a request:

using var httpRequestMessage = new HttpRequestMessage
{
    Method = HttpMethod.Post,
    RequestUri = new("http://localhost/images/12345"),
};
_ = await _httpClient.SendAsync(httpRequestMessage, cancellationToken).ConfigureAwait(false);

Expected behavior

Either of those:

• An option to redact the URI which is enabled by default

HttpMethod:POST
Uri:http://localhost/images/<this was redacted>
{OriginalFormat}:HTTP {HttpMethod} {Uri} 

• Remove Uri from logging

Actual behavior

ILogger's scope contains this:

HttpMethod:POST
Uri:http://localhost/images/12345
{OriginalFormat}:HTTP {HttpMethod} {Uri} 

where 12345 is my privacy information

Regression?

No response

Known Workarounds

The only way is services.RemoveAll<IHttpMessageHandlerBuilderFilter>(); which is harsh. I need logging, but don't want to be exposed to a risk of leaking sensitive information

Configuration

No response

Other information

No response

Author:	evgenyfedorov2
Assignees:	-
Labels:	area-System.Net.Http, untriaged
Milestone:	-

[CarnaViire]

Thank you @evgenyfedorov2
This is a dupe of #68675, so I'm going to close this one.
Please upvote #68675 if you need this feature, it would help us prioritize. Thanks!

[CarnaViire]

Duplicate of #68675

[xakep139]

Hey @CarnaViire, isn't #68675 only about query parameters?

[CarnaViire]

@xakep139 oh right, thanks for pointing that out. But let's gather all additional requirements in one place.