Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Dynamic VSD stub calls should also reuse indirection cell #76302

Open
jakobbotsch opened this issue Sep 28, 2022 · 1 comment
Open

JIT: Dynamic VSD stub calls should also reuse indirection cell #76302

jakobbotsch opened this issue Sep 28, 2022 · 1 comment
Assignees
@jakobbotsch
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Future

Comments

@jakobbotsch
Copy link
Member

jakobbotsch commented Sep 28, 2022 •
edited by BruceForstall
Loading

For static VSD stub calls we avoid creating any control expression and just do the call by dereferencing the indirection cell during codegen. For VSD stub calls that are dynamically computed we should be able to do the same thing. See #76017 (comment) for a regression where it matters.

category:cq
theme:optimization
skill-level:intermediate
cost:small
impact:small
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Sep 28, 2022
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Sep 28, 2022
@ghost
Copy link

ghost commented Sep 28, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

For static VSD stub calls we avoid creating any control expression and just do the call by dereferencing the indirection cell during codegen. For VSD stub calls that are dynamically computed we should be able to do the same thing. See #76017 (comment) for a regression where it matters.

Author: jakobbotsch
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

@jakobbotsch jakobbotsch self-assigned this Sep 28, 2022
@jakobbotsch jakobbotsch added this to the 8.0.0 milestone Sep 28, 2022
@jakobbotsch jakobbotsch removed the untriaged New issue has not been triaged by the area owner label Sep 28, 2022
@jakobbotsch jakobbotsch modified the milestones: 8.0.0, Future Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@jakobbotsch