Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regressions in System.Globalization.Tests.StringSearch #78512

Closed
performanceautofiler bot opened this issue Nov 17, 2022 · 6 comments
Closed

Regressions in System.Globalization.Tests.StringSearch #78512

performanceautofiler bot opened this issue Nov 17, 2022 · 6 comments
Assignees
@EgorBo
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone
8.0.0

Comments

@performanceautofiler
Copy link

Run Information

Architecture arm64
OS Windows 10.0.19041
Baseline 4820105ba85531da5b388e7b2e98fdcdae9ced07
Compare 2b1f57e08b26879e4fa99670df078b77c848d9e0
Diff Diff

Regressions in System.Globalization.Tests.StringSearch

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
IsPrefix_DifferentFirstChar - Duration of single invocation 6.07 ns 9.74 ns 1.60 0.32 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Globalization.Tests.StringSearch*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.Globalization.Tests.StringSearch.IsPrefix_DifferentFirstChar(Options: (en-US, OrdinalIgnoreCase, False))

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 9.739572823923629 > 6.5487494770685135.
IsChangePoint: Marked as a change because one of 8/17/2022 3:53:31 PM, 11/11/2022 8:39:50 AM, 11/17/2022 1:45:21 AM falls between 11/8/2022 10:18:07 AM and 11/17/2022 1:45:21 AM.
IsRegressionStdDev: Marked as regression because -20.734846741647367 (T) = (0 -9.442781279773007) / Math.Sqrt((0.08514831912942529 / (19)) + (0.29674831130818136 / (17))) is less than -2.0322445093148245 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (19) + (17) - 2, .025) and -0.48198912743797667 = (6.371694032666377 - 9.442781279773007) / 6.371694032666377 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository
@performanceautofiler performanceautofiler bot added arm64 untriaged New issue has not been triaged by the area owner labels Nov 17, 2022
This was referenced Nov 17, 2022
Open
Closed
Closed
@dakersnar dakersnar transferred this issue from dotnet/perf-autofiling-issues Nov 17, 2022
@ghost
Copy link

ghost commented Nov 17, 2022

Tagging subscribers to this area: @dotnet/area-system-globalization
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture arm64
OS Windows 10.0.19041
Baseline 4820105ba85531da5b388e7b2e98fdcdae9ced07
Compare 2b1f57e08b26879e4fa99670df078b77c848d9e0
Diff Diff

Regressions in System.Globalization.Tests.StringSearch

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
IsPrefix_DifferentFirstChar - Duration of single invocation 6.07 ns 9.74 ns 1.60 0.32 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Globalization.Tests.StringSearch*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.Globalization.Tests.StringSearch.IsPrefix_DifferentFirstChar(Options: (en-US, OrdinalIgnoreCase, False))

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 9.739572823923629 > 6.5487494770685135.
IsChangePoint: Marked as a change because one of 8/17/2022 3:53:31 PM, 11/11/2022 8:39:50 AM, 11/17/2022 1:45:21 AM falls between 11/8/2022 10:18:07 AM and 11/17/2022 1:45:21 AM.
IsRegressionStdDev: Marked as regression because -20.734846741647367 (T) = (0 -9.442781279773007) / Math.Sqrt((0.08514831912942529 / (19)) + (0.29674831130818136 / (17))) is less than -2.0322445093148245 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (19) + (17) - 2, .025) and -0.48198912743797667 = (6.371694032666377 - 9.442781279773007) / 6.371694032666377 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: -
Labels:

area-System.Globalization, untriaged
Milestone: -

@dakersnar
Copy link
Contributor

Likely caused by #77947 @EgorBo

@dakersnar dakersnar added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark labels Nov 17, 2022
@dakersnar dakersnar changed the title [Perf] Windows/arm64: 1 Regression on 11/11/2022 1:18:55 PM Regressions in System.Globalization.Tests.StringSearch Nov 17, 2022
@dakersnar dakersnar mentioned this issue Nov 17, 2022
Closed
@tarekgh tarekgh added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-System.Globalization labels Nov 17, 2022
@ghost
Copy link

ghost commented Nov 17, 2022

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

Run Information

Architecture arm64
OS Windows 10.0.19041
Baseline 4820105ba85531da5b388e7b2e98fdcdae9ced07
Compare 2b1f57e08b26879e4fa99670df078b77c848d9e0
Diff Diff

Regressions in System.Globalization.Tests.StringSearch

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
IsPrefix_DifferentFirstChar - Duration of single invocation 6.07 ns 9.74 ns 1.60 0.32 False

graph
Test Report

Repro

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net6.0 --filter 'System.Globalization.Tests.StringSearch*'

Related Issues

Regressions

Improvements

Payloads

Baseline
Compare

Histogram

Edge Detector Info

Collection Data

System.Globalization.Tests.StringSearch.IsPrefix_DifferentFirstChar(Options: (en-US, OrdinalIgnoreCase, False))

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionWindowed: Marked as regression because 9.739572823923629 > 6.5487494770685135.
IsChangePoint: Marked as a change because one of 8/17/2022 3:53:31 PM, 11/11/2022 8:39:50 AM, 11/17/2022 1:45:21 AM falls between 11/8/2022 10:18:07 AM and 11/17/2022 1:45:21 AM.
IsRegressionStdDev: Marked as regression because -20.734846741647367 (T) = (0 -9.442781279773007) / Math.Sqrt((0.08514831912942529 / (19)) + (0.29674831130818136 / (17))) is less than -2.0322445093148245 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (19) + (17) - 2, .025) and -0.48198912743797667 = (6.371694032666377 - 9.442781279773007) / 6.371694032666377 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author: performanceautofiler[bot]
Assignees: -
Labels:

tenet-performance, tenet-performance-benchmarks, area-CodeGen-coreclr, untriaged
Milestone: -

@tarekgh
Copy link
Member

tarekgh commented Nov 17, 2022

Changing the area label as look @EgorBo would be the best person to take the first look.

@EgorBo
Copy link
Member

EgorBo commented Nov 17, 2022

This is likely a stale PGO + smaller-than-simd size case, regressed by a SIMD path condition.
The change brought nice improvements in other benchmarks: #77947 (comment)

I'll wait for static pgo to update to see if it helps.

@EgorBo EgorBo removed the untriaged New issue has not been triaged by the area owner label Nov 17, 2022
@EgorBo EgorBo self-assigned this Nov 17, 2022
@EgorBo EgorBo added this to the 8.0.0 milestone Nov 17, 2022
@EgorBo
Copy link
Member

EgorBo commented Apr 24, 2023

Perf is better now, the difference is 2ns so unlike worth investigating

image

@EgorBo EgorBo closed this as completed Apr 24, 2023
@ghost ghost locked as resolved and limited conversation to collaborators May 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@EgorBo EgorBo

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Milestone
8.0.0
Development

No branches or pull requests
3 participants
@EgorBo @tarekgh @dakersnar