CI: *Lot* of builds broken - System/Numerics/Matrix4x4.cs(1785,43): error CA1857: The argument should be a constant for optimal performance

[radical]

PR builds are broken, for example - (this)(https://dev.azure.com/dnceng-public/public/_build/results?buildId=127542&view=logs&j=72f9df23-c01e-561c-b579-6959c020a69b&t=8974e4e0-e2d2-5d20-4c75-b6a799880c93).

  System.Private.CoreLib -> /__w/1/s/artifacts/bin/System.Private.CoreLib/ref/Checked/net8.0/System.Private.CoreLib.dll
/__w/1/s/src/libraries/System.Private.CoreLib/src/System/Numerics/Matrix4x4.cs(1785,43): error CA1857: The argument should be a constant for optimal performance [/__w/1/s/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
##[error]src/libraries/System.Private.CoreLib/src/System/Numerics/Matrix4x4.cs(1785,43): error CA1857: (NETCORE_ENGINEERING_TELEMETRY=Build) The argument should be a constant for optimal performance
/__w/1/s/src/libraries/System.Private.CoreLib/src/System/Numerics/Matrix4x4.cs(1789,50): error CA1857: The argument should be a constant for optimal performance [/__w/1/s/src/coreclr/System.Private.CoreLib/System.Private.CoreLib.csproj]
##[error]src/libraries/System.Private.CoreLib/src/System/Numerics/Matrix4x4.cs(1789,50): error CA1857: (NETCORE_ENGINEERING_TELEMETRY=Build) The argument should be a constant for optimal performance

This seems to be related to #80192 .

cc @tannergooding

Report

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
0	0	0

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[tannergooding]

PR fix is here: #80282

It's unclear why this didn't fail in regular CI. Will look into that after the fix is merged.

[radical]

PR fix is here: #80282

Thanks for the lightning fast response :)

It's unclear why this didn't fail in regular CI. Will look into that after the fix is merged.

Yeah, very strange. I thought this - #80149 - enables CA1857, but that's not merged yet. 🤷‍♂️

[tannergooding]

Perhaps the wasm build is configured for a different set of rules atm?

[radical]

But this shows coreclr builds failing too.

[tannergooding]

Hmmm, its definitely unclear to me then. I will continue investigating further.

[stephentoub]

#80149 makes it explicit, but that analyzer is a warning by default. The analyzer wasn't available in this repo until #79685 was merged, so #80192 didn't actually have the analyzer.

[radical]

Oh, the builds from your #80192 are from yesterday evening. And a new roslyn update(#79685) was ingested after that which likely added/enabled this new analyzer.