Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JIT: Teach physical promotion to peel FIELD_ADDR nodes #88386

Open
jakobbotsch opened this issue Jul 4, 2023 · 2 comments
Open

JIT: Teach physical promotion to peel FIELD_ADDR nodes #88386

jakobbotsch opened this issue Jul 4, 2023 · 2 comments
Assignees
@jakobbotsch
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
10.0.0

Comments

@jakobbotsch
Copy link
Member

#88109 (comment)

Block morphing gets it for free because they get morphed away. In physical promotion it's a bit more complicated as we need to guarantee the right null checking behavior.
@jakobbotsch jakobbotsch self-assigned this Jul 4, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jul 4, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 4, 2023
@ghost
Copy link

ghost commented Jul 4, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

#88109 (comment)

Block morphing gets it for free because they get morphed away. In physical promotion it's a bit more complicated as we need to guarantee the right null checking behavior.

Author: jakobbotsch
Assignees: jakobbotsch
Labels:

area-CodeGen-coreclr
Milestone: -

@jakobbotsch jakobbotsch removed the untriaged New issue has not been triaged by the area owner label Jul 4, 2023
@jakobbotsch
Copy link
Member Author

bit more complicated as we need to guarantee the right null checking behavior.

Actually may not be too bad given that we are going to dereference the FIELD_ADDR immediately anyway, so it may just fall out from the null check insertion logic that is already there.

@JulieLeeMSFT JulieLeeMSFT added this to the 8.0.0 milestone Jul 6, 2023
@jakobbotsch jakobbotsch modified the milestones: 8.0.0, Future Jul 14, 2023
@jakobbotsch jakobbotsch modified the milestones: Future, 9.0.0 Aug 11, 2023
@jakobbotsch jakobbotsch mentioned this issue Aug 11, 2023
Open
@jakobbotsch jakobbotsch modified the milestones: 9.0.0, 10.0.0 Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jakobbotsch jakobbotsch

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
2 participants
@jakobbotsch @JulieLeeMSFT