Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optimization for scalar conversion of float/double to ulong. #89279

Closed
anthonycanino opened this issue Jul 20, 2023 · 4 comments
Closed

Add optimization for scalar conversion of float/double to ulong. #89279

anthonycanino opened this issue Jul 20, 2023 · 4 comments
Assignees
@kunalspathak @anthonycanino
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI avx512 Related to the AVX-512 architecture
Milestone
9.0.0

Comments

@anthonycanino
Copy link
Contributor

anthonycanino commented Jul 20, 2023 •
edited by BruceForstall
Loading

AVX512VL adds a number of new scalar conversion for unsigned 32-bit/64-bit integer types to float/double. This issue is meant to address some cases that were not implemented in a previous PR #84384, notably

  • double to ulong
  • float to ulong
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 20, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 20, 2023
@anthonycanino anthonycanino mentioned this issue Jul 20, 2023
Closed
@ghost
Copy link

ghost commented Jul 21, 2023

Tagging subscribers to this area: @dotnet/area-system-numerics
See info in area-owners.md if you want to be subscribed.

Issue Details

AVX512VL adds a number of new scalar conversion for unsigned 32-bit/64-bit integer types to float/double. This PR is meant to address osme cases that were not implemented in a previous PR #84384, notably

double to ulong
float to ulong

Author: anthonycanino
Assignees: -
Labels:

area-System.Numerics, untriaged, needs-area-label
Milestone: -

@teo-tsirpanis teo-tsirpanis removed the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 21, 2023
@tannergooding tannergooding removed the untriaged New issue has not been triaged by the area owner label Jul 21, 2023
@tannergooding tannergooding added this to the 9.0.0 milestone Jul 21, 2023
@BruceForstall BruceForstall added avx512 Related to the AVX-512 architecture area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed area-System.Numerics labels Jul 21, 2023
@ghost
Copy link

ghost commented Jul 21, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

AVX512VL adds a number of new scalar conversion for unsigned 32-bit/64-bit integer types to float/double. This issue is meant to address some cases that were not implemented in a previous PR #84384, notably

  • double to ulong
  • float to ulong
Author: anthonycanino
Assignees: -
Labels:

area-CodeGen-coreclr, arch-avx512
Milestone: 9.0.0

@BruceForstall BruceForstall mentioned this issue Jul 21, 2023
Closed
56 tasks
@BruceForstall BruceForstall mentioned this issue Oct 9, 2023
Closed
33 tasks
@huoyaoyuan huoyaoyuan mentioned this issue Dec 11, 2023
Closed
@BruceForstall
Copy link
Member

@anthonycanino @khushal1996 @DeepakRajendrakumaran Is this issue resolved with the merge of #97529?

@tannergooding
Copy link
Member

This was completed in #97529 and #100993

@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kunalspathak kunalspathak

@anthonycanino anthonycanino

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI avx512 Related to the AVX-512 architecture
Projects
None yet
Milestone
9.0.0
Development

No branches or pull requests
6 participants
@jeffschwMSFT @tannergooding @BruceForstall @kunalspathak @teo-tsirpanis @anthonycanino