Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review usages of impGetNodeAddr with ignored flags #89372

Open
MichalPetryka opened this issue Jul 23, 2023 · 1 comment
Open

Review usages of impGetNodeAddr with ignored flags #89372

MichalPetryka opened this issue Jul 23, 2023 · 1 comment
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Milestone
Future

Comments

@MichalPetryka
Copy link
Contributor

#85562 made impGetNodeAddr return flags the original access would use. Places that use the API but ignore the returned flags have been marked with // TODO-Bug?: verify if flags matter here.
All such cases should be reviewed and either documented to be fine or fixed to not ignore the flags.
cc @SingleAccretion
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jul 23, 2023
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jul 23, 2023
@MichalPetryka MichalPetryka changed the title Review usages of impGetNodeAddr for ignored flags Review usages of impGetNodeAddr with ignored flags Jul 23, 2023
@SingleAccretion SingleAccretion added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI and removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jul 23, 2023
@SingleAccretion SingleAccretion added this to the Future milestone Jul 23, 2023
@ghost
Copy link

ghost commented Jul 23, 2023

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Issue Details

#85562 made impGetNodeAddr return flags the original access would use. Places that use the API but ignore the returned flags have been marked with // TODO-Bug?: verify if flags matter here.
All such cases should be reviewed and either documented to be fine or fixed to not ignore the flags.
cc @SingleAccretion

Author: MichalPetryka
Assignees: -
Labels:

area-CodeGen-coreclr
Milestone: -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
Future
Development

No branches or pull requests
2 participants
@MichalPetryka @SingleAccretion