Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PERF] Regressions in WASM AOT x64 in Logging.Formatting and IndexOf #92163

Open
DrewScoggins opened this issue Sep 15, 2023 · 2 comments
Open

[PERF] Regressions in WASM AOT x64 in Logging.Formatting and IndexOf #92163

DrewScoggins opened this issue Sep 15, 2023 · 2 comments
Assignees
@radekdoulik
Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Milestone
10.0.0

Comments

@DrewScoggins
Copy link
Member

These two issues were found during the manual performance comparison for 8.0 RC1.

https://pvscmdupload.blob.core.windows.net/reports/allTestHistory%2frefs%2fheads%2fmain_x64_ubuntu%2018.04_AOT%3dtrue_CompilationMode%3dwasm_RunKind%3dmicro%2fSystem.Memory.Span(Int32).IndexOfAnyTwoValues(Size%3a%20512).html

Unfortunately, the range for this regression is quite large. 15d7761...74d69fd

The second issue is https://pvscmdupload.blob.core.windows.net/reports/allTestHistory%2frefs%2fheads%2fmain_x64_ubuntu%2018.04_AOT%3dtrue_CompilationMode%3dwasm_RunKind%3dmicro%2fMicrosoft.Extensions.Logging.Formatting.TwoArguments.html

And the commit range is 56552c2...7036cba
@dotnet-issue-labeler dotnet-issue-labeler bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 15, 2023
@ghost ghost added the untriaged New issue has not been triaged by the area owner label Sep 15, 2023
@DrewScoggins DrewScoggins added tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark and removed untriaged New issue has not been triaged by the area owner needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 15, 2023
@DrewScoggins DrewScoggins mentioned this issue Sep 15, 2023
Closed
@SamMonoRT SamMonoRT added the arch-wasm WebAssembly architecture label Sep 20, 2023
@ghost
Copy link

ghost commented Sep 20, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

These two issues were found during the manual performance comparison for 8.0 RC1.

https://pvscmdupload.blob.core.windows.net/reports/allTestHistory%2frefs%2fheads%2fmain_x64_ubuntu%2018.04_AOT%3dtrue_CompilationMode%3dwasm_RunKind%3dmicro%2fSystem.Memory.Span(Int32).IndexOfAnyTwoValues(Size%3a%20512).html

Unfortunately, the range for this regression is quite large. 15d7761...74d69fd

The second issue is https://pvscmdupload.blob.core.windows.net/reports/allTestHistory%2frefs%2fheads%2fmain_x64_ubuntu%2018.04_AOT%3dtrue_CompilationMode%3dwasm_RunKind%3dmicro%2fMicrosoft.Extensions.Logging.Formatting.TwoArguments.html

And the commit range is 56552c2...7036cba

Author: DrewScoggins
Assignees: -
Labels:

arch-wasm, tenet-performance, tenet-performance-benchmarks, area-VM-meta-mono
Milestone: -

@SamMonoRT SamMonoRT added this to the 9.0.0 milestone Sep 20, 2023
@SamMonoRT
Copy link
Member

Marking for 9.0, but please consider backport to 8.0 servicing for fixes.

@lewing lewing modified the milestones: 9.0.0, 10.0.0 Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radekdoulik radekdoulik

Labels
arch-wasm WebAssembly architecture area-Codegen-AOT-mono tenet-performance Performance related issue tenet-performance-benchmarks Issue from performance benchmark
Projects
None yet
Milestone
10.0.0
Development

No branches or pull requests
5 participants
@lewing @radekdoulik @DrewScoggins @jeffschwMSFT @SamMonoRT