Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up and refactoring ProcessFrameworkReferences #12117

Closed
wli3 opened this issue Jun 20, 2020 · 1 comment
Closed

Clean up and refactoring ProcessFrameworkReferences #12117

wli3 opened this issue Jun 20, 2020 · 1 comment
Assignees
@wli3
Milestone
6.0.1xx

Comments

@wli3
Copy link

wli3 commented Jun 20, 2020

#11824

There are some clean up need to make for above PR. ProcessFrameworkReferences need to have more unit test. And the methods in ProcessFrameworkReferences is too long.
@wli3 wli3 added this to the 5.0.1xx milestone Jun 20, 2020
@wli3 wli3 self-assigned this Jun 20, 2020
@wli3 wli3 mentioned this issue Jun 20, 2020
Merged
@sfoslund sfoslund mentioned this issue Jun 25, 2020
Merged
@sfoslund
Copy link
Member

#12199 fixes a bug from the original PR and cleans up comments. Leaving this issue open to track refactoring the task as a whole, which is long and convoluted.

@wli3 wli3 modified the milestones: 5.0.1xx, 6.0.1xx Aug 23, 2020
@wli3 wli3 closed this as completed Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wli3 wli3

Labels
None yet
Projects
None yet
Milestone
6.0.1xx
Development

No branches or pull requests
2 participants
@wli3 @sfoslund