Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Allow modifying other files than AndroidManifest.xml #55

Open
calimeroteknik opened this issue Jun 8, 2016 · 3 comments
Open

Comments

@calimeroteknik
Copy link

I was very happy to find this plugin, but I'd like to add resources in res/values/strings.xml.
Could it be allowed?
Well, that part isn't hard: there is a check for the filename to be 'AndroidManifest.xml', which can be removed.

However, the object PLATFORM_CONFIG_FILES's contents would need to be determined either by looking at the backup directory's contents, or the list of modified files in config.xml.

Here is the diff of the changes I made in order for it to work for one extra file:
cordova-custom-config-additionalfile.txt

@djett41
Copy link

djett41 commented Jan 30, 2017

@calimeroteknik the best thing for you to do would be to just create a custom plugin with a plugin.xml and add your customizations there. This plugin actually is an updated version of a hook I contributed to the yeoman ionic generator, and I created this for iOS/Android because I wasnt as familiar with custom plugins and plugin.xml. But if you get the hang of it, and create a custom plugin, you wont need this plugin and wont be limited on configuring your project

@dpa99c
Copy link
Owner

dpa99c commented Jan 31, 2017

@djett41 Thanks for creating the original hook script. I really only created this plugin out of my necessity to customise the native project config in a CI (non-local) build environment and I think there's still a place for this plugin to avoid needing to create a custom plugin every time you want to customise the native project config. Having said that, I'm hoping that soon it will become redundant if Cordova itself is able to support in config.xml tags that are currently only supported by plugin.xml (e.g. <config-file/>, <framework/>, <source-file/>)

@djett41
Copy link

djett41 commented Feb 20, 2017

@dpa99c no prob my man! youre right there is value to this plugin since Cordova still doesnt fully support certain things through the CLI

@dpa99c dpa99c changed the title Allow modifying other files than AndroidManifest.xml [FEATURE] Allow modifying other files than AndroidManifest.xml Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants