Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prediction fails when a base model does not have an associated verifier model #18

Closed
dscripka opened this issue Mar 5, 2023 · 1 comment
Closed

Prediction fails when a base model does not have an associated verifier model #18

dscripka opened this issue Mar 5, 2023 · 1 comment
Assignees
@dscripka
Labels
bug Something isn't working

Comments

@dscripka
Copy link
Owner

dscripka commented Mar 5, 2023

When a user instantiates a Model object with custom verifier models but only for a subset of the loaded base models, prediction will fail as it expects every base model to have a verifier.

The correct behavior should just skip the verification stage for base models that don't have an associated verifier model.
@dscripka dscripka added the bug Something isn't working label Mar 5, 2023
@dscripka dscripka self-assigned this Mar 5, 2023
@dscripka dscripka changed the title Prediction fails when a base model doesnt' have an associated verifier model Prediction fails when a base model does not have an associated verifier model Mar 5, 2023
@dscripka
Copy link
Owner Author

dscripka commented Mar 6, 2023 •
edited
Loading

This issue has been fixed with release v0.3.1.

@dscripka dscripka closed this as completed Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dscripka dscripka

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dscripka