Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify/Split auth_controller #168

Open
3 tasks
nelsonic opened this issue Nov 30, 2021 · 1 comment
Open
3 tasks

Simplify/Split auth_controller #168

nelsonic opened this issue Nov 30, 2021 · 1 comment
Labels
chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T4h Time Estimate 4 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies

Comments

@nelsonic
Copy link
Member

As noted by @SimonLab in the PR #159 the auth_controller is way too big.
The file is currently 507 lines. This is far too long.

@doc """
`logout/2` logs the person out of their session and destroys cookie.
"""
def logout(conn, params) do
conn
# |> Auth.Session.end_session()
|> AuthPlug.logout()
|> put_flash(:info, "Successfully logged out.")
|> index(params)
end
end

Todo

  • Review the file and determine if we can extract generic/helper functions
  • Extract email+password related auth code into its own file, filename at your discretion.
  • Remove OAuth (Google / GitHub) related code
@nelsonic nelsonic transferred this issue from dwyl/auth_plug Dec 18, 2021
@nelsonic nelsonic added chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T4h Time Estimate 4 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies labels Dec 29, 2021
@nelsonic nelsonic pinned this issue Mar 21, 2022
@nelsonic
Copy link
Member Author

Gonna do this as part of #207 👌

@nelsonic nelsonic unpinned this issue Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a tedious but necessary task often paying technical debt enhancement New feature or enhancement of existing functionality priority-2 Second highest priority, should be worked on as soon as the Priority-1 issues are finished T4h Time Estimate 4 Hours technical A technical issue that requires understanding of the code, infrastructure or dependencies
Projects
None yet
Development

No branches or pull requests

1 participant