Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add badge to GitHub Pages #60

Open
arboriculteurs opened this issue Jan 23, 2019 · 5 comments
Open

Add badge to GitHub Pages #60

arboriculteurs opened this issue Jan 23, 2019 · 5 comments
Labels

Comments

@arboriculteurs
Copy link

Is it possible to have the badge displayed not in the Readme file but in the index page of a website hosted on GitHub Pages ? Thanks a lot

@nelsonic
Copy link
Member

@arboriculteurs good question is that a feature you would find useful? 🤔

@arboriculteurs
Copy link
Author

Thanks a lot for your prompt response...
Yes, I find it very useful. Because I learn to associations how to create free websites with Jekyll. And because of EU regulations, we want a web counter that works on Github pages, do not rely on external services with advertisements et uses no cookies. So no Google stats...
Your badge seems to be perfect if it could be put on another page than the readme.

@nelsonic
Copy link
Member

@arboriculteurs have you tried it...? 😉 (it's a general web counter so it will work anywhere)
(also for GDPR compliance you need to be in control of the data that is being collected, so if a user of your service requests deletion of their personal data (of which IP address counts), you must be able to delete it. So using the Hits badge which pushes IP address and "page view" data to my database is probably not compliant from your perspective...)
Given that all the code is Open Source you consider adapting it to run on your own App e.g. on Heroku Free tier. and thus maintain control of all the data and be able to run your own analysis.

@arboriculteurs
Copy link
Author

Yes, of course, I did. I putted the markdown snippet on the footer of a Jekyll generated page, but nothing happened.
I have not noticed that you collect the IP to... But an IP without any other personnal information should be considered compliant with GDPR.
Thanks for all the advices : I will try again.

@nelsonic
Copy link
Member

@arboriculteurs unless you have a markdown parsing step in your Jekyll build it won't work like that.
You need to use HTML.
Please note that Hits was not intended to be a "analytics as a [free] service" so definitely consider running your own instance of Hits on Heroku or equivalent free hosting service.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants