Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEV telemetry not working in full node #1847

Open
livthomas opened this issue Jul 4, 2024 · 3 comments
Open

MEV telemetry not working in full node #1847

livthomas opened this issue Jul 4, 2024 · 3 comments
Labels

Comments

@livthomas
Copy link

Right now, MEV telemetry does not send any data to the target service when you start a full node. Even though this feature is implemented in both ProcessProposalHandler and FullNodeProcessProposalHandler, it simply does not work when running in the full node mode.

We suspect it might be caused by an error which causes the handler to return. It looks like these errors are being swallowed as we don't see anything in the logs. See the code above the sending logic in FullNodeProcessProposalHandler.

This is the command we used when starting the node:

/home/dydx/bin/dydxprotocold start \
        --home "/home/dydx/.dydxprotocol" \
        --p2p.seeds="ade4d8bc8cbe014af6ebdf3cb7b1e9ad36f412c0@seeds.polkachu.com:23856,65b740ee326c9260c30af1f044e9cda63c73f7c1@seeds.kingnodes.net:23856,f04a77b92d0d86725cdb2d6b7a7eb0eda8c27089@dydx-mainnet-seed.bwarelabs.com:36656,20e1000e88125698264454a884812746c2eb4807@seeds.lavenderfive.com:23856,c2c2fcb5e6e4755e06b83b499aff93e97282f8e8@tenderseed.ccvalidators.com:26401,4f20c3e303c9515051b6276aeb89c0b88ee79f8f@seed.dydx.cros-nest.com:26656,a9cae4047d5c34772442322b10ef5600d8e54900@dydx-mainnet-seednode.allthatnode.com:26656,802607c6db8148b0c68c8a9ec1a86fd3ba606af6@64.227.38.88:26656,4c30c8a95e26b07b249813b677caab28bf0c54eb@rpc.dydx.nodestake.top:666,ebc272824924ea1a27ea3183dd0b9ba713494f83@dydx-mainnet-seed.autostake.com:27366" \
        --non-validating-full-node=true \
        --mev-telemetry-enabled \
        --mev-telemetry-identifier "dydx-node-main-01" \
        --mev-telemetry-hosts "https://my-dydx-mev-service.example.com"
Copy link

linear bot commented Jul 4, 2024

@yang-dydx
Copy link
Contributor

Turns out you have to set --non-validating-full-node=false and --mev-telemetry-enabled=true. The MEV telemetry needs the oracle price calculation which doesn't exist in full node mode.

Obviously this is really confusing, but this is a quick workaround before team fixes this.

@livthomas
Copy link
Author

@yang-dydx We have already been using it this way. I just wanted to point out that it's not working in the full node mode even though the code is there. We spent a lot of time figuring out what was wrong until we found this workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants