Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement CAW (Creation Authorship Window) #260

Open
5 tasks done
huzaifa-99 opened this issue Jan 11, 2023 · 5 comments
Open
5 tasks done

Implement CAW (Creation Authorship Window) #260

huzaifa-99 opened this issue Jan 11, 2023 · 5 comments
Assignees
Labels

Comments

@huzaifa-99
Copy link
Member

huzaifa-99 commented Jan 11, 2023

There is creation authorship time window which missed some implementation details.

We want to do these changes

  • 1- Whenever a creation is created, we add a temporary authorship to the user who created the creation. This authorship will be permanent after the CAW window is passed for the author and full authorship will be transferred. There will be some DB changes required. (has some bits in Inform users about the finalisation date #278)
  • 2- Add authorship assignment logic after CAW window is passed. ( Issue on finalising the creation during the litigation process #304)
  • 3- Only allow litigations for creation in CAW and block for non CAW creations. These will be simple conditionals/checks.
  • 4- Pause the CAW time window if the creation/material is in litigation phase (in this case the time to finalise authorship is CAW + Litigation Time)
  • 5- Update creation CAW based on assumed author response in litigation reconciliation window
@huzaifa-99
Copy link
Member Author

@AltiMario for 2, will this be a background process?

If it is a background process, we might have to do something similar to a cron job, that looks for CAW window dates and does the authorship changes.

We can also do this based on user input. Put simply, user will press a button (Something like Redeem Authorship) and they will be confirmed as author. This button will work/show after CAW.

@huzaifa-99
Copy link
Member Author

huzaifa-99 commented Jan 11, 2023

Just had a thought about reputation stars looking at this ticket.

What if the user updates their personal info, as we currently calculate stars based on the user provided info. Let’s say Bob creates a creation when he has 4 stars, after that he updates his profile removes some info and now he has 2 stars. Will we change the CAW window based on the new stars?

Alternatively, I think we should make it hard for users to change their reputation stars (stars that are calculated based on user profile info like email, phone) very fast, having some kind of cooldown period to update stars after the user updates their profile (maybe I am totally wrong) 


@AltiMario
Copy link
Sponsor Member

@huzaifa-99 I know this is a perfect scenario for an async process but I prefer not to have anything like that at this stage.
Let's manage it the same as we did in the previous scenarios, using a "redeem" button as you proposed.
About the other question, when the CAW is calculated (after the creation process) this info has to be stored as well based on the current reputation of the user. If in the meantime the user increases or decreases in reputation, the logic doesn't change because the one that refers is the CAW calculated (and stored) on the first instance.
I'm not very much in favour of a cooldown period, only because it is a further thing to learn for the user (that is already overwhelmed with things in this app).

@huzaifa-99
Copy link
Member Author

All points implemented in #314

@AltiMario
Copy link
Sponsor Member

for a proper test of the CAW a debug tool is needed
#304 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants