API tools report error in Gerrit on test projects but not in SDK

[iloveeclipse]

See https://ci.eclipse.org/platform/job/eclipse.platform.releng/job/PR-78/1/console

This PR eclipse-platform/eclipse.platform.releng#78 shows errors because of API tools complaining in gerrit.

They were introduced in eclipse-platform/eclipse.platform.releng#77 but PR was merged anyway.

However: there are ZERO API tools errors in SDK, I'm using latest nightly build as of now.

I believe that somewhere someone added validation for test projects, not sure why it wasn't working before.

Either we have to fix SDK or Gerrit job, but we can't keep reporting errors only in one instance.

[INFO] Command line:
	[/opt/tools/java/openjdk/jdk-11/latest/bin/java, -Xmx2048M, -Dp2.RepositoryPreferences.retryOnSocketTimeout=true, -Dp2.RepositoryPreferences.connectionRetryCount=3, -Dp2.RepositoryPreferences.connectionMsRetryDelay=500, -Dorg.eclipse.ecf.provider.filetransfer.retrieve.readTimeout=10000, -jar, /home/jenkins/agent/workspace/eclipse.platform.releng_PR-78/.m2/repository/p2/osgi/bundle/org.eclipse.equinox.launcher/1.6.400.v20210924-0641/org.eclipse.equinox.launcher-1.6.400.v20210924-0641.jar, -install, /home/jenkins/agent/workspace/eclipse.platform.releng_PR-78/apiAnalyzer-workspace, -configuration, /home/jenkins/agent/workspace/eclipse.platform.releng_PR-78/apiAnalyzer-workspace/configuration, -data, /home/jenkins/agent/workspace/eclipse.platform.releng_PR-78/apiAnalyzer-workspace/data, -application, org.eclipse.pde.api.tools.apiAnalyzer, -project, /home/jenkins/agent/workspace/eclipse.platform.releng_PR-78/bundles/org.eclipse.test.performance, -baseline, /home/jenkins/agent/workspace/eclipse.platform.releng_PR-78/bundles/org.eclipse.test.performance/target/org.eclipse.test.performance-apiBaseline.target, -dependencyList, /home/jenkins/agent/workspace/eclipse.platform.releng_PR-78/bundles/org.eclipse.test.performance/target/dependencies-list.txt, -failOnError]
3 API ERRORS
* Marker [on: /org.eclipse.test.performance/META-INF/MANIFEST.MF, id: 33, type: org.eclipse.pde.api.tools.version_numbering, attributes: [apiMarkerID: 4, charEnd: 175, charStart: 157, description: - The type org.eclipse.test.internal.performance.data.ResultsData has been added to org.eclipse.test.performance_3.18.100
- The type org.eclipse.test.performance.BasicResultsTable has been added to org.eclipse.test.performance_3.18.100
, lineNumber: 5, message: The minor version should be incremented in version 3.18.100, since new APIs have been added since version 3.18.0, messagearguments: 3.18.100#3.18.0, problemid: 924844039, severity: 2, sourceId: API Tools, version: 3.19.0.qualifier], created: 7/27/22, 6:43 AM]
* Marker [on: /org.eclipse.test.performance/src/org/eclipse/test/internal/performance/data/ResultsData.java, id: 31, type: org.eclipse.pde.api.tools.marker.sincetags, attributes: [apiMarkerID: 5, charEnd: 957, charStart: 946, lineNumber: 28, message: Missing @since tag on org.eclipse.test.internal.performance.data.ResultsData, messagearguments: org.eclipse.test.internal.performance.data.ResultsData, org.eclipse.jdt.internal.core.JavaModelManager.handleId: =org.eclipse.test.performance/src<org.eclipse.test.internal.performance.data{ResultsData.java[ResultsData, problemTypeName: org.eclipse.test.internal.performance.data.ResultsData, problemid: 1110441988, severity: 2, sourceId: API Tools, version: 3.18], created: 7/27/22, 6:43 AM]
* Marker [on: /org.eclipse.test.performance/src/org/eclipse/test/performance/BasicResultsTable.java, id: 32, type: org.eclipse.pde.api.tools.marker.sincetags, attributes: [apiMarkerID: 5, charEnd: 1115, charStart: 1098, lineNumber: 30, message: Missing @since tag on org.eclipse.test.performance.BasicResultsTable, messagearguments: org.eclipse.test.performance.BasicResultsTable, org.eclipse.jdt.internal.core.JavaModelManager.handleId: =org.eclipse.test.performance/src<org.eclipse.test.performance{BasicResultsTable.java[BasicResultsTable, problemTypeName: org.eclipse.test.performance.BasicResultsTable, problemid: 1110441988, severity: 2, sourceId: API Tools, version: 3.18], created: 7/27/22, 6:43 AM] 

[laeubi]

I noticed that missing since tags can occur (with other strange problems) when ApiTools do not find the packages/folders in the output folder:

• [apitools] Use the AST/JDT to discover package names #801
• [apitools] no API error reported with missing bin folder #791

so it could even report NO ERRORS at all if there is a problem discovering the packages...