Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Y build is failing #1759

Closed
jarthana opened this issue Jan 31, 2024 · 14 comments
Closed

Y build is failing #1759

jarthana opened this issue Jan 31, 2024 · 14 comments

Comments

@jarthana
Copy link
Contributor

Y build has started failing with this new error:

13:38:53 Caused by: org.apache.maven.plugin.MojoFailureException: Cannot resolve dependencies of project eclipse.platform.releng.tychoeclipsebuilder:equinox-sdk:eclipse-repository:4.31.0-SNAPSHOT 13:38:53 with context {osgi.os=linux, osgi.ws=gtk, org.eclipse.update.install.features=true, org.eclipse.jdt.buildtime=true, osgi.arch=x86_64} 13:38:53 Software being installed: org.eclipse.equinox.sdk.product 4.31.0.qualifier 13:38:53 Missing requirement: org.eclipse.equinox.sdk.feature.group 3.23.1100.v20240129-1338 requires 'org.eclipse.equinox.p2.iu; org.eclipse.jdt.core.compiler.batch [3.37.0.v20240129-0421,3.37.0.v20240129-0421]' but it could not be found 13:38:53 Cannot satisfy dependency: org.eclipse.equinox.sdk.product 4.31.0.qualifier depends on: org.eclipse.equinox.p2.iu; org.eclipse.equinox.sdk.feature.group 0.0.0 13:38:53 at org.eclipse.tycho.p2tools.RepositoryReferenceTool.addTargetPlatformRepository (RepositoryReferenceTool.java:158)

Not sure if this is something to do with JDT bundle versions, but I can see earlier in the log that we indeed built the bundle with that version (org.eclipse.jdt.core.compiler.batch-3.37.0-SNAPSHOT.jar)

@MohananRahul
Copy link
Contributor

I think need to update ECJ to 3.37.0.v20240129-0421, since YBuild is using latest ECJ

@jarthana
Copy link
Contributor Author

jarthana commented Feb 1, 2024

Just spoke to @sravanlakkimsetti. He says the issue is that feature gets the qualifier from the I build. I am not sure I fully understand this issue, but this is something @laeubi will know?

@laeubi
Copy link
Contributor

laeubi commented Feb 1, 2024

I'm not sure what an Y-build does so whats the source of an Y-Build?

@jarthana
Copy link
Contributor Author

jarthana commented Feb 1, 2024

I'm not sure what an Y-build does so whats the source of an Y-Build?

It's same as I build, except that the involved projects (that is JDT ones) come from the BETA_JAVA22 branch and the others come from the master branch.

@laeubi
Copy link
Contributor

laeubi commented Feb 1, 2024

Hm... it looks like you need to touch the feature then in the Y branches to account for a changed compiler. Or remove compiler from org.eclipse.equinox.sdk as it will be pulled in indirectly by jdt.core anyways...

@jarthana
Copy link
Contributor Author

jarthana commented Feb 1, 2024

Hm... it looks like you need to touch the feature then in the Y branches to account for a changed compiler. Or remove compiler from org.eclipse.equinox.sdk as it will be pulled in indirectly by jdt.core anyways...

This was Sravan's recommendation too. But with both master and this branch evolving, this might become a regular affair.

@laeubi
Copy link
Contributor

laeubi commented Feb 1, 2024

As said I think the batch compiler (that might be the only that change?) does not need to be part of the feature at all.

@iloveeclipse
Copy link
Member

does not need to be part of the feature at all.

Note: the batch compiler is not only needed by JDT but by the help component and may be other components that need a Java compiler library but don't need JDT Core &Co.

@merks
Copy link
Contributor

merks commented Feb 1, 2024

Yes, by the JSP support in the help system.

image

@laeubi
Copy link
Contributor

laeubi commented Feb 1, 2024

does not need to be part of the feature at all.

Note: the batch compiler is not only needed by JDT but by the help component and may be other components that need a Java compiler library but don't need JDT Core &Co.

If it is required it will be included without being mentioned in any feature at all....

@MohananRahul
Copy link
Contributor

does not need to be part of the feature at all.

Note: the batch compiler is not only needed by JDT but by the help component and may be other components that need a Java compiler library but don't need JDT Core &Co.

If it is required it will be included without being mentioned in any feature at all....

But IBuild will fail without mentioning it in feature #1251 (comment)

@akurtakov
Copy link
Member

@MohananRahul Have you confirmed this is still the case? The build system is improving constantly and many things that needed extra manual configuration now work automatically.

@MohananRahul
Copy link
Contributor

MohananRahul commented Feb 2, 2024

Tested locally it failed
image

@akurtakov
Copy link
Member

Closing as I see https://ci.eclipse.org/releng/job/YPBuilds/job/Y-build-4.31/28/ successful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants