Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection does not consider line-spacing #2307

Open
2 tasks done
albertmink opened this issue Sep 20, 2024 · 3 comments
Open
2 tasks done

Selection does not consider line-spacing #2307

albertmink opened this issue Sep 20, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@albertmink
Copy link

Let's make sure issue is not already fixed in latest builds first.

Steps to reproduce

From a fresh installation and clean workspace:

  • Set line spacing > 0
image

I tried

  • *select a character or a word *

I expected: that selection marker extend over the line-spacing

But got: The selected character/word is displayed as if line-spacing were 0
select-with-line-spacing-40

Here is some relevant log output

From <workspace>/.metadata/.log

<relevant log output>

Tested under this environment:

  • OS & version: ...
  • Eclipse IDE/Platform version (as shown in Help > About): ...
  • ...Anything else that can be useful...

Community

  • I understand reporting an issue to this OSS project does not mandate anyone to fix it. Other contributors may consider the issue, or not, at their own convenience. The most efficient way to get it fixed is that I fix it myself and contribute it back as a good quality patch to the project.
@albertmink albertmink added the bug Something isn't working label Sep 20, 2024
@jukzi
Copy link
Contributor

jukzi commented Sep 20, 2024

Did you read that?
image
Do you plan to contribute a PR that does the job?

@BeckerWdf
Copy link
Contributor

Did you read that? image Do you plan to contribute a PR that does the job?

I don't think that his sentence relates to this issue. The extra linespacing setting has some issues - so I would say it's simply a bug.
Pls. have a look at eclipse-platform/eclipse.platform.swt#1329.
There we did a fix for the selection in such cases. How is your case different?

@albertmink
Copy link
Author

@BeckerWdf let's consider three cases: ( I just wanted to play with this feature 🥲 )

(1) see initial post.
select-with-line-spacing-40

(2) selecting multi line (partial)
Screenshot 2024-09-20 at 15 49 32
(3) selecting multi line (entire)
Screenshot 2024-09-20 at 15 50 03

Let's say only (3) looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants