Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] : Version 5.1.6 doesn't build correctly #413

Closed
stef-corilus opened this issue Jun 6, 2024 · 4 comments
Closed

[Bug] : Version 5.1.6 doesn't build correctly #413

stef-corilus opened this issue Jun 6, 2024 · 4 comments

Comments

@stef-corilus
Copy link

Our pipeline installed the 5.1.6 version automatically. However, the installation via npm doesn't go as expected. We get the following error on the npm install (and on the ‘editorconfig-checker -version' command):

/usr/local/lib/node_modules/editorconfig-checker/dist/index.js:11
/*! formdata-polyfill. MIT License. Jimmy Wärting <[https://jimmy.warting.se/opensource>
                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                            

SyntaxError: Unexpected identifier
    at internalCompileFunction (node:internal/vm:76:18)
    at wrapSafe (node:internal/modules/cjs/loader:1283:20)
    at Module._compile (node:internal/modules/cjs/loader:1328:27)
    at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    at Module.load (node:internal/modules/cjs/loader:1203:32)
    at Module._load (node:internal/modules/cjs/loader:1019:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    at node:internal/main/run_main_module:28:49

Node.js v18.20.3

I had to shorten the trace, because it was too long.

@theoludwig
Copy link
Member

Indeed, thank you for the report.
Sorry for the troubles, will revert the changes for now.

@theoludwig
Copy link
Member

I think it's related to this issue: vercel/ncc#1193

@theoludwig
Copy link
Member

Ok, I'm very sorry, seems like the issue persists, with the revert of the 2 commits of the release.

In fact, the problematic commit is this one: d1f6ab1.

I reverted the problematic commit, and released v5.1.8, also I improved the CI, so this kind of issue should not happen again. We will directly know if the @vercel/ncc build fails.

@stef-corilus
Copy link
Author

Yes it seems like this solves the issue, thanks for the quick response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants