Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy loading broken for SSR #15

Closed
manniL opened this issue Jan 9, 2019 · 6 comments
Closed

Lazy loading broken for SSR #15

manniL opened this issue Jan 9, 2019 · 6 comments
Labels

Comments

@manniL
Copy link
Contributor

manniL commented Jan 9, 2019

Heya!

Finally did the switch for https://github.com/Developmint/nuxt-svg-loader thanks to @wagerfield.

And something broke 🙈 😛

I can't lazy-load components with it anymore on server-side:
Repro: https://mj87xr1kyp.sse.codesandbox.io/

Somehow this happens only sometimes with just one lazyloaded SVG but always with 2+.

PS: This was/is possible with https://github.com/visualfanatic/vue-svg-loader.

image

@manniL manniL changed the title Lazy loading Lazy loading broken for SSR Jan 9, 2019
@manniL
Copy link
Contributor Author

manniL commented Jan 9, 2019

Researched a bit and it could be an issue with template functional and Nuxt.

Would it be possible to move the things to a functional render function?

@egoist
Copy link
Owner

egoist commented Jan 11, 2019

@manniL we could do that, but we need to add HMR support manually. (should be easy though.)

@manniL
Copy link
Contributor Author

manniL commented Jan 11, 2019

@egoist Awesome! A non-functional template would be fine too if that'd be easier.

@egoist
Copy link
Owner

egoist commented Jan 11, 2019

@manniL yeah, from I've heard from Evan, we don't need functional components just for perf gains in Vue 3 either, I will update it to use stateful component 👌🏻

@manniL
Copy link
Contributor Author

manniL commented Jan 11, 2019

@egoist Heard that too 🙊
Many thanks! ☺️

@egoist egoist closed this as completed in ce94c85 Jan 11, 2019
@egoist
Copy link
Owner

egoist commented Jan 11, 2019

🎉 This issue has been resolved in version 0.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants