Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

k8s Metadata TODOs for v8.0.0 #16483

Closed
4 tasks done
ChrsMark opened this issue Feb 21, 2020 · 4 comments
Closed
4 tasks done

k8s Metadata TODOs for v8.0.0 #16483

ChrsMark opened this issue Feb 21, 2020 · 4 comments
Assignees
Labels
autodiscovery breaking change containers Related to containers use case Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team v8.0.0

Comments

@ChrsMark
Copy link
Member

ChrsMark commented Feb 21, 2020

This issue aims to keep track of changes that should be applied on metadata Generators for all the different resources.

Final decision was taken in #16558

cc: @exekias @vjsamuel

ps: assigning this to myself so as not to get forgotten :)

@ChrsMark ChrsMark added containers Related to containers use case Team:Integrations Label for the Integrations team breaking change v8.0.0 autodiscovery Team:Platforms Label for the Integrations - Platforms team labels Feb 21, 2020
@ChrsMark ChrsMark self-assigned this Feb 21, 2020
@exekias
Copy link
Contributor

exekias commented Feb 24, 2020

I'm not quite convinced about moving pod labels to kubernetes.pod.labels. In general, having labels under a common place allow for correlation. For instance, give me all resources with label env: production. We should come up with a plan about this

@ChrsMark
Copy link
Member Author

ChrsMark commented Feb 3, 2021

I'm not quite convinced about moving pod labels to kubernetes.pod.labels. In general, having labels under a common place allow for correlation. For instance, give me all resources with label env: production. We should come up with a plan about this

Plan was discussed and defined at #16558

@ChrsMark
Copy link
Member Author

@MichaelKatsoulis I guess we are ok to close this one?

@MichaelKatsoulis
Copy link
Contributor

Yes I will close that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autodiscovery breaking change containers Related to containers use case Team:Integrations Label for the Integrations team Team:Platforms Label for the Integrations - Platforms team v8.0.0
Projects
None yet
Development

No branches or pull requests

4 participants