Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for 7.17.0 is missing a breaking change in the Filebeat config #32095

Open
OvervCW opened this issue Jun 24, 2022 · 3 comments
Open
Labels
Stalled Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team

Comments

@OvervCW
Copy link

OvervCW commented Jun 24, 2022

I just upgraded Filebeat from 7.16.1 to 7.17.0 and it started failing to startup with the following message:

2022-06-24T15:26:54.345Z	INFO	instance/beat.go:497	filebeat stopped.
2022-06-24T15:26:54.345Z	ERROR	instance/beat.go:1014	Exiting: Failed to start crawler: starting input failed: error while initializing input: fail to unpack the kubernetes configuration: invalid logs_path defined for resource_type: container, valid value is `/var/log/containers/` accessing 'filebeat.inputs.0.processors.0.add_kubernetes_metadata' (source:'filebeat.yml')
Exiting: Failed to start crawler: starting input failed: error while initializing input: fail to unpack the kubernetes configuration: invalid logs_path defined for resource_type: container, valid value is `/var/log/containers/` accessing 'filebeat.inputs.0.processors.0.add_kubernetes_metadata' (source:'filebeat.yml')

This happened because my configuration used the path /var/log/containers instead of /var/log/containers/ (note the trailing slash):

filebeat.inputs:
  - type: container
    paths:
      - "/var/log/containers/*.log"
    processors:
      - add_kubernetes_metadata:
          default_indexers.enabled: false
          default_matchers.enabled: false
          indexers:
            - container:
          matchers:
            - logs_path:
                logs_path: "/var/log/containers"
                resource_type: "container"

This was a bit puzzling because this configuration has been working fine for a long time. I think that the validation added as part of #28868 should either be changed to tolerate paths without trailing slashes or the release notes for 7.17.0 should mention this as a breaking change.

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 24, 2022
@jsoriano jsoriano added the Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team label Jul 4, 2022
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 4, 2022
@botelastic
Copy link

botelastic bot commented Jul 4, 2023

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jul 4, 2023
@OvervCW
Copy link
Author

OvervCW commented Jul 4, 2023

👍

@botelastic botelastic bot removed the Stalled label Jul 4, 2023
@botelastic
Copy link

botelastic bot commented Aug 20, 2024

Hi!
We just realized that we haven't looked into this issue in a while. We're sorry!

We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1.
Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stalled Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Development

No branches or pull requests

2 participants