Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation to ensure source/destination are populated as a priority #948

Closed
2 tasks done
webmat opened this issue Aug 20, 2020 · 4 comments
Closed
2 tasks done
Assignees

Comments

@webmat
Copy link
Contributor

webmat commented Aug 20, 2020

The definition of the Client & Server field sets are pretty extensive, whereas Source & Destination's definitions are pretty bare.

We've been encouraging people to populate source & destination as a baseline, and client & server only when relevant or helpful. Elastic Security mostly considers source & destination.

However the ECS documentation doesn't make that obvious. There's only a vague mention about prioritizing source/destination in the client/server definitions. No mention of this in source/destination.

  • Expand definitions of source and destination field sets #967 We should expand the definitions of the source & destination field sets to clearly state that they are the baseline, compared to client & server.
  • Add mapping network event guidance doc #969 We could also consider having a standalone documentation page that talks about capturing network related events holistically. It could cover:
    • the src/dst baseline, and showcase when cli/srv are useful (e.g. DNS)
    • it could discuss populating the network.* fields
    • it could discuss how event.category:network + event.type:protocol should always come with network.protocol:[appropriate protocol name]. Most category/type pairs are complete on their own. But not the pair network/protocol; it should come with network.protocol.
@ebeahan
Copy link
Member

ebeahan commented Aug 20, 2020

We could also consider having a standalone documentation page that talks about capturing network related events holistically

++ I think this makes a lot of sense to capture this and in the future other ECS design patterns.

@ghost
Copy link

ghost commented Aug 21, 2020

Thank you for raising this!

@ebeahan ebeahan self-assigned this Sep 8, 2020
@ebeahan
Copy link
Member

ebeahan commented Sep 14, 2020

@jamesmotherway I've opened #967 aiming to address the first bullet point, if you have any feedback there.

@ebeahan
Copy link
Member

ebeahan commented Sep 29, 2020

Closing as #967 and #969 have both been merged 🎉

@ebeahan ebeahan closed this as completed Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants