Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting] Exclude security and stack monitoring rule types from rule export. #101270

Closed
ymao1 opened this issue Jun 3, 2021 · 5 comments · Fixed by #102999
Closed

[Alerting] Exclude security and stack monitoring rule types from rule export. #101270

ymao1 opened this issue Jun 3, 2021 · 5 comments · Fixed by #102999
Assignees
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@ymao1
Copy link
Contributor

ymao1 commented Jun 3, 2021

Based on discussions about potential duplication of security and stack monitoring rules, we want to filter out these rules types on export.

This depends on #99680. Once that is resolved, we can remove the feature flag for rule import/export and filter out security and stack monitoring rules in the rule onExport hook.

@botelastic botelastic bot added the needs-team Issues missing a team label label Jun 3, 2021
@ymao1
Copy link
Contributor Author

ymao1 commented Jun 3, 2021

When this issue is resolved, we need follow-up issues for un-excluding security and stack monitoring rules.

To be able to include security rules in our export, #87992, #99741 need to be resolved.

To be able to include stack monitoring rules in our export, the issues in this meta issue must be resolved.

@ymao1 ymao1 added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Jun 3, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Jun 3, 2021
@pmuellr
Copy link
Member

pmuellr commented Jun 9, 2021

Would it make any sense to have a rule-type indicate whether it's rules can be exported or not? Default that they can be exported (of course). I have a feeling like we'll end up seeing this again in the future ...

@ymao1 ymao1 removed the blocked label Jun 21, 2021
@ymao1
Copy link
Contributor Author

ymao1 commented Jun 21, 2021

#99680 has been resolved so this issue is no longer blocked.

@ymao1
Copy link
Contributor Author

ymao1 commented Jun 29, 2021

When this issue is resolved, we need follow-up issues for un-excluding security and stack monitoring rules.

To be able to include security rules in our export, #87992, #99741 need to be resolved.

To be able to include stack monitoring rules in our export, the issues in this meta issue must be resolved.

Followup issues:

@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
5 participants