Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RAC] Change @timestamp value to be last updated #107636

Closed
jasonrhodes opened this issue Aug 4, 2021 · 9 comments · Fixed by #108029
Closed

[RAC] Change @timestamp value to be last updated #107636

jasonrhodes opened this issue Aug 4, 2021 · 9 comments · Fixed by #108029
Assignees
Labels
Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete v7.15.0

Comments

@jasonrhodes
Copy link
Member

jasonrhodes commented Aug 4, 2021

📝 Summary

The Observability Alerts table's at the moment has a Triggered column, which reads the value from kibana.alert.start

✔️ Acceptance criteria

  • this column should read the timestamp value (last updated for that alert document) and not the "triggered" value that we read from now.
  • the label should be updated to Last updated
@jasonrhodes jasonrhodes added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Aug 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@jasonrhodes jasonrhodes added v7.15.0 Theme: rac label obsolete labels Aug 4, 2021
@mgiota mgiota self-assigned this Aug 9, 2021
@mgiota
Copy link
Contributor

mgiota commented Aug 9, 2021

@jasonrhodes I'll update the value to be read from kibana.alert.rule.updated_at.

Regarding the label we display in the header I had last updated in my mind, but security uses @timestamp, so maybe we should be consistent with them. What did you have in mind?

cc @mdefazio @weltenwort

@weltenwort
Copy link
Member

"Last Updated" seems most descriptive to me. In contrast, "@timestamp" doesn't convey the meaning of the point in time.

@mdefazio
Copy link
Contributor

mdefazio commented Aug 9, 2021

If my thinking is correct, Security won't benefit from a 'Last updated' label. Their alerts will occur at a specific point in time and live on until an action is done on them. So timestamp makes sense for them. I get this is different for Obs alert classes.

So I'm open to discuss how to try and keep consistency here but obviously try and be clear enough. Would duration go off last updated? Would last updated change only between alert groups (Warning --> Critical --> Warning)?

@mgiota
Copy link
Contributor

mgiota commented Aug 10, 2021

@weltenwort I am checking the implementation and at the moment we don't index kibana.alert.rule.updated_at. Let's quickly bring this into our today's rac sync. @mdefazio Good points, we'll discuss further today

@weltenwort
Copy link
Member

Isn't @timestamp updated on every change?

@mgiota
Copy link
Contributor

mgiota commented Aug 10, 2021

Yep I just realized this, so I can use the @timestamp field

@katrin-freihofner
Copy link
Contributor

Related: #108035

@mgiota
Copy link
Contributor

mgiota commented Aug 11, 2021

Related: #107639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Theme: rac label obsolete v7.15.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants