Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting] Remove state variables from action variable menu in UI #122989

Closed
ymao1 opened this issue Jan 13, 2022 · 3 comments · Fixed by #123702
Closed

[Alerting] Remove state variables from action variable menu in UI #122989

ymao1 opened this issue Jan 13, 2022 · 3 comments · Fixed by #123702
Assignees
Labels
estimate:small Small Estimated Level of Effort Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@ymao1
Copy link
Contributor

ymao1 commented Jan 13, 2022

We currently do not pass state variables for recovered alerts but they do show up in the action variable menu dropdown when the Recovered action group is selected. This should be hidden, similar to how context variables are hidden for Recovered action groups.

@ymao1 ymao1 added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Alerting/RulesManagement Issues related to the Rules Management UX estimate:small Small Estimated Level of Effort labels Jan 13, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@pmuellr
Copy link
Member

pmuellr commented Jan 25, 2022

For some reason I thought we were removing the state variables from ALL the action groups, not just recovered. I guess that's the easiest thing to do today, in case users are using state variables today, they might be confused if they didn't see them listed in a future version of Kibana, for non-recovered action groups.

Commenting here after seeing the video in [Alerting] Remove state variables from action variable menu #123702 (but haven't actually reviewed yet - thanks for the video!!!)

@ymao1
Copy link
Contributor Author

ymao1 commented Jan 26, 2022

@pmuellr There are some rule types (uptime mostly) that put all of their variables into state. We will have to work with them to move what makes sense to context before removing state entirely from the UI.

@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
estimate:small Small Estimated Level of Effort Feature:Alerting/RulesManagement Issues related to the Rules Management UX Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants