Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discuss] create Kibana alerts with expressions #50270

Closed
mikecote opened this issue Nov 12, 2019 · 8 comments
Closed

[Discuss] create Kibana alerts with expressions #50270

mikecote opened this issue Nov 12, 2019 · 8 comments
Labels
blocked core services Issues related to enabling features across Kibana to leverage core services across domains discuss enhancement New value added to drive a business result estimate:needs-research Estimated as too large and requires research to break down into workable issues Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

mikecote commented Nov 12, 2019

Expression alerts

If we want to support expression alerts, we need to support running expressions server side. This has a lot of considerations.

  • What about expression functions that can only run browser side? How do they indicate that?

  • What about data fetching expression functions that use our search services. Our search services currently have a client side component that returns an observable and handles polling background searches and reporting progress. The server side search strategies return a promise and return partial results immediately.

What if the user wants to create an expression alert and get alerted when the search hits a certain progress? Is there any use case for this? Is progress only important client side?

Search strategies that can execute on server and client side

Considerations:

  • What about requestPreference which is a client side only setting so it's unique to the user? Can we detect the environment and conditionally add this only on client side?
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services (Team:Stack Services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers lukeelmers added the Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) label Jan 21, 2020
@ppisljar
Copy link
Member

there are very few expression functions that can only run browser side and i think for those we could provide mocked version on the server side. for example the location function which gets location from your browser could accept a parameter defaultLocation, which would be used on the browser when user declined to share his location or on the server.

we plan to change the data.search contracts so they will match on server and on the client. If they wouldn't we would need a different implementation of esaggs function on the server and on the client but we are hoping to avoid that.

@ppisljar
Copy link
Member

ppisljar commented Mar 9, 2020

this seems like a duplicate of #46906 where we track the progress of server side expressions, please reopen if that is not correct

@ppisljar ppisljar closed this as completed Mar 9, 2020
@pmuellr
Copy link
Member

pmuellr commented Mar 9, 2020

This isn't a dup of issue #46906, but that issue is a blocker for this one.

The idea for this issue is to allow customers to build alerts with expressions. Those expressions will need to be executed server-side, hence the blocker on #46906 .

Beyond that, we don't yet know what else will be needed to be done, because we haven't really done too much thinking on this. Certainly we'll need to provide some additional expression functions related to alerting / actions.

I'll go ahead and change this to a discuss as well, which I think was the original intention.

@pmuellr pmuellr reopened this Mar 9, 2020
@pmuellr pmuellr changed the title Kibana expression style alerts [Discuss] create Kibana alerts with expressions Mar 9, 2020
@pmuellr pmuellr added discuss and removed Feature:ExpressionLanguage Interpreter expression language (aka canvas pipeline) Team:AppArch labels Mar 9, 2020
@pmuellr
Copy link
Member

pmuellr commented Mar 9, 2020

I removed labels not directly related to alerting, as at this state, this is all stuff alerting needs to figure out.

I noticed the issue is in the kibana-app-arch project, but I'm hesitant to remove cards from other folk's projects - I think it can be removed from that project though ...

@mikecote
Copy link
Contributor Author

mikecote commented Jun 4, 2020

I'm adding this issue back to triage for the alerting team. After a good chat with App Arch and Kibana App team, there is still a large effort to do on their side before accomplishing this and realistically not something that will be done until 8.x. This will probably be moved to Long Term in the project.

@gmmorris gmmorris added the Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types label Jul 1, 2021
@gmmorris gmmorris added the loe:needs-research This issue requires some research before it can be worked on or estimated label Jul 14, 2021
@gmmorris gmmorris added enhancement New value added to drive a business result core services Issues related to enabling features across Kibana to leverage core services across domains estimate:needs-research Estimated as too large and requires research to break down into workable issues and removed Feature:Alerting labels Aug 13, 2021
@gmmorris gmmorris removed the loe:needs-research This issue requires some research before it can be worked on or estimated label Sep 2, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
@mikecote
Copy link
Contributor Author

Closing due to lack of activity and interest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked core services Issues related to enabling features across Kibana to leverage core services across domains discuss enhancement New value added to drive a business result estimate:needs-research Estimated as too large and requires research to break down into workable issues Feature:Alerting/RuleTypes Issues related to specific Alerting Rules Types Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

No branches or pull requests

10 participants