Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should an alert action be assignable to multiple action groups? #67863

Open
mikecote opened this issue Jun 1, 2020 · 3 comments
Open

Should an alert action be assignable to multiple action groups? #67863

mikecote opened this issue Jun 1, 2020 · 3 comments
Labels
discuss estimate:needs-research Estimated as too large and requires research to break down into workable issues Feature:Alerting/RuleActions Issues related to the Actions attached to Rules on the Alerting Framework Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

mikecote commented Jun 1, 2020

It was discussed while designing #64077 if an alert action should be assigned to more than a single action group. What this would mean is that you can provide a single message for different actions group of an alert (example: warning, alert).

The structure would change from:

actions: [
  {
    group: 'default',
    actionTypeId: '123',
    params: {},
  }
]

to:

actions: [
  {
    group: ['default', 'warning'],
    actionTypeId: '123',
    params: {},
  }
]

This may also need a mustache template variable to know what group the action is rendering for.

@mikecote mikecote added discuss Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Jun 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@pmuellr
Copy link
Member

pmuellr commented Jun 4, 2020

Noting that this is a rare structure change that doesn't require a change to ES mappings (changing a field from a single to array value requires no ES mapping change).

However, it is a type change. We could probably change the TS type to string | string[], but then it will be rather messy to access, and long term we want it as string[]. So we may need some "migration" in the end, though we could probably just do it on the reading of the SO.

@gmmorris gmmorris added the Feature:Alerting/RuleActions Issues related to the Actions attached to Rules on the Alerting Framework label Jul 1, 2021
@gmmorris gmmorris added the loe:needs-research This issue requires some research before it can be worked on or estimated label Jul 14, 2021
@YulNaumenko
Copy link
Contributor

@arisonl do you have more concrete customers enhancements for this?

@gmmorris gmmorris added the estimate:needs-research Estimated as too large and requires research to break down into workable issues label Aug 18, 2021
@gmmorris gmmorris removed the loe:needs-research This issue requires some research before it can be worked on or estimated label Sep 2, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss estimate:needs-research Estimated as too large and requires research to break down into workable issues Feature:Alerting/RuleActions Issues related to the Actions attached to Rules on the Alerting Framework Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
No open projects
Development

No branches or pull requests

6 participants