Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Disable base as a required package #69483

Closed
ruflin opened this issue Jun 18, 2020 · 7 comments
Closed

[Ingest Manager] Disable base as a required package #69483

ruflin opened this issue Jun 18, 2020 · 7 comments
Assignees
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@ruflin
Copy link
Member

ruflin commented Jun 18, 2020

The assets in the base package are installed by Elasticsearch directly in the future. As soon as elastic/elasticsearch#57629 is merged, base can be dropped from the list of packages that are required to be installed when Kibana is first accessed.

Elasticsearch loads the assets if they don't exist yet, but all future updates to these assets will have to be done by the Ingest Manager. It means we still need to base package and figure out how we update these assets if needed. As these assets are very basic, the hope is that they will be updated rarely.

This issue is mainly to disable it and make sure all things still work and then create a follow up issue to discuss, how we will update these assets in the future.

@ruflin ruflin added Team:Fleet Team label for Observability Data Collection Fleet team Ingest Management:beta1 labels Jun 18, 2020
@ruflin ruflin self-assigned this Jun 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@ph
Copy link
Contributor

ph commented Jun 18, 2020

@ruflin One question I had yesterday from out chat with lee is we did remove some fields in the template that will be installed by Elasticsearch, Should our base template be a 1:1 match of the installed tempalte. or should this base template be already an upgrade and we just install it by default even if ES has the base template installed.

@ruflin
Copy link
Member Author

ruflin commented Jun 18, 2020

I think it should be a 1:1 match, so we need to update our base package.

@ruflin ruflin removed their assignment Jun 22, 2020
@ph
Copy link
Contributor

ph commented Jun 29, 2020

Steps to do:

  1. Remove the base as required package is only required for b1.
  2. Update the base package with the change from Elasticsearch in the above PR.
  3. Figure out how to update Elasticsearch's base assets with the package registry assets.

@ph ph self-assigned this Jun 29, 2020
@skh
Copy link
Contributor

skh commented Jul 9, 2020

Is there more to do than what was implemented in #70437 ?

@ph ph assigned ruflin and unassigned ph Jul 9, 2020
@ph
Copy link
Contributor

ph commented Jul 9, 2020

@skh You are correct, will reassign it to ruflin to make sure we are good.

@ruflin
Copy link
Member Author

ruflin commented Jul 23, 2020

Closing as I think all the work was done.

@ruflin ruflin closed this as completed Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

4 participants