Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tighten deprecation warning for plugin lifecycles that return Promises #71925

Closed
joshdover opened this issue Jul 15, 2020 · 1 comment · Fixed by #89562
Closed

Tighten deprecation warning for plugin lifecycles that return Promises #71925

joshdover opened this issue Jul 15, 2020 · 1 comment · Fixed by #89562
Assignees
@pgayvallet
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@joshdover
Copy link
Contributor

joshdover commented Jul 15, 2020 •
edited by pgayvallet
Loading

Related to #53268

We should start logging deprecation warnings in development for any plugins that return a Promise from their setup or start methods (stop does not currently support Promises at all it technically does, it's just undocumented).

We should also decrease the timeout from 30s to 10s to help nudge plugins away from async lifecycles.

This should be done on both the client and server side.
@joshdover joshdover changed the title Add deprecation warning for plugin lifecycles that return Promises Tighten deprecation warning for plugin lifecycles that return Promises Jul 15, 2020
@joshdover joshdover added Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Jul 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@joshdover joshdover self-assigned this Aug 3, 2020
@joshdover joshdover mentioned this issue Aug 3, 2020
Closed
2 tasks
@joshdover joshdover removed their assignment Dec 2, 2020
@pgayvallet pgayvallet mentioned this issue Jan 29, 2021
Merged
2 tasks
@pgayvallet pgayvallet self-assigned this Feb 3, 2021
@pgayvallet pgayvallet mentioned this issue Feb 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pgayvallet pgayvallet

Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate most plugins to synchronous lifecycle pgayvallet/kibana
3 participants
@pgayvallet @joshdover @elasticmachine