Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas][Telemetry] Add schema to canvas collector #75746

Closed
Bamieh opened this issue Aug 24, 2020 · 2 comments · Fixed by #78481
Closed

[Canvas][Telemetry] Add schema to canvas collector #75746

Bamieh opened this issue Aug 24, 2020 · 2 comments · Fixed by #78481
Labels
Feature:Canvas Feature:Telemetry Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@Bamieh
Copy link
Member

Bamieh commented Aug 24, 2020

Canvas collector fetch function is currently typed with any and misisng a schema field.

The collector is currently excluded from the telemetry check to ensure we always have the mapping upto date and adheres to what the best practices of the telemetry team

  • [canvas] "x-pack/plugins/canvas/server/collectors/collector.ts"

It would be great if the canvas team can add the schema to the collector to help us keep the telemetry cluster mappings updated and ensure any changes adhere to our best practices.

Context: #70180
@Bamieh Bamieh added Feature:Telemetry Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Aug 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@afharo afharo linked a pull request Sep 29, 2020 that will close this issue
[Usage Collection] [schema] Support spreads + canvas definition #78481
Merged
1 task
@afharo
Copy link
Member

afharo commented Sep 29, 2020

Resolved by the PR #78481

@afharo afharo closed this as completed Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Canvas Feature:Telemetry Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Usage Collection] [schema] Support spreads + canvas definition afharo/kibana
4 participants
@marius-dr @afharo @Bamieh @elasticmachine