Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should alert action params form clear values when changing "Run when"? #83916

Closed
mikecote opened this issue Nov 20, 2020 · 1 comment · Fixed by #84202
Closed

Should alert action params form clear values when changing "Run when"? #83916

mikecote opened this issue Nov 20, 2020 · 1 comment · Fixed by #84202
Assignees
Labels
discuss Feature:Actions Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

I was testing this PR (#83226) which now sets defaults based on action type and action group (really great!). Since some default values are set each time the "run when" changes, the defaults get blended with existing values by overwriting them.

I'm opening this issue to discuss what behaviour we should have? Keep everything as is? Clear all form values and apply defaults each time the "run when" changes? Clear some form values and apply defaults each time?

Scenario with #83226:

  1. Create a PagerDuty connector
  2. Fill out a create alert form
  3. Add PagerDuty connector
  4. Set PagerDuty summary to "Alert condition is met!"
  5. Change "Run when" to "Resolved"

You'll notice the form is in a state like below where "event action" is now "Resolve" but the old summary is now irrelevant.

Screenshot Screen Shot 2020-11-20 at 8 43 38 AM

Note from @ymao1

I feel like the expected behavior might be different per connector or even connector field. If I filled out my email address but forgot to change the "Run when", it would be annoying to have that cleared

cc @mdefazio

@mikecote mikecote added discuss Feature:Alerting Feature:Actions Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Nov 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:Actions Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants