Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Advanced Settings] Reset to default button doesn't appear with empty strings #84876

Closed
markov00 opened this issue Dec 3, 2020 · 1 comment · Fixed by #85137
Closed

[Advanced Settings] Reset to default button doesn't appear with empty strings #84876

markov00 opened this issue Dec 3, 2020 · 1 comment · Fixed by #85137
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@markov00
Copy link
Member

markov00 commented Dec 3, 2020

Kibana version:
I've checked that this issue is present since 6.7

Describe the bug:
In the advanced settings, when you clear (completely remove the format) a field like the Date format, the Reset to default button doesn't appear below the field. This can trick the user to think that this is the default value, causing few issues with visualizations that rely on that format.

Steps to reproduce:

  1. Open the Advanced Settings
  2. Go to Date Format, clean the field and save
  3. theReset to default button is not present
  4. now add a single character, save, the Reset to default button is there

Expected behavior:

The reset to default button should appear every time the field differs from the actual default value.

Screenshots (if relevant):

Dec-03-2020 11-01-04

Errors in browser console (if relevant):
N/A

@markov00 markov00 added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages labels Dec 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants